Page MenuHomePhabricator

MobileFrontend sometimes goes to diff page instead of pending changes review page
Closed, ResolvedPublicBUG REPORT

Description

If I want to review a change at Special:PendingChanges, when pressing the review button on a mobile device (or with the MobileFrontend enabled) I'll be taken to the Special:MobileDiff page without having the option to review that diff. Sometimes I can review the diff but for most of the time, I can't.

Related Objects

StatusSubtypeAssignedTask
ResolvedBUG REPORTJdlrobson
ResolvedNone
Resolvedovasileva
ResolvedJdlrobson
ResolvedAmmarpad
OpenNone
ResolvedJdlrobson
ResolvedJdlrobson
Resolvedphuedx
ResolvedJdlrobson
Resolvedovasileva
Resolved marcella
Resolvedmatmarex
ResolvedBUG REPORTEsanders
Resolvedovasileva
Resolvedovasileva
ResolvedJdlrobson
InvalidNone
Resolved jkroll
OpenFeatureNone
OpenNone
ResolvedJdlrobson
ResolvedJdlrobson
ResolvedJdlrobson
DeclinedNone
ResolvedNone
ResolvedBUG REPORTSBisson
ResolvedJdlrobson
ResolvedBUG REPORTJdlrobson
ResolvedJSengupta-WMF
OpenBUG REPORTNone
OpenBUG REPORTNone
ResolvedJdlrobson

Event Timeline

Diffs have nothing to do with Minerva. That's MobileFrontend.

ovasileva triaged this task as Medium priority.Sep 1 2020, 3:56 PM
ovasileva moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.

This will need to be done in FlaggedRevs. Given T185664 not likely to happen.

Tacsipacsi changed the subtype of this task from "Task" to "Bug Report".
Tacsipacsi subscribed.

Why should FlaggedRevs clean up the mess created by MobileFrontend adding a new special page? Special:MobileDiff not only provides a completely different UI, but also doesn’t provide the standard hook DifferenceEngineViewHeader that FlaggedRevs wants to use. Yes, it provides its own hook BeforeSpecialMobileDiffDisplay—with a different name and completely different signature. We could probably add an extra compatibility layer in FlaggedRevs to support MobileFrontend—and any other extension that relies on the standard hook—, but MF is (kind of) broken here, not FR.


By the way,

Sometimes I can review the diff but for most of the time, I can't.

I think it depends on how many revisions are there to review: if only one, then Special:MobileDiff takes over the diff display and breaks the mechanism adding the review form; if there are multiple revisions, the native MediaWiki diff appears, which contains the review form. (Yet another argument against Special:MobileDiff—it’s not even self-consistent, sometimes it appears, sometimes it doesn’t.)

Why should FlaggedRevs clean up the mess created by MobileFrontend adding a new special page?

It doesn't have to, but MobileFrontend is not going to address this problem.

The long-term plan with MobileFrontend is to merge the functionality with the desktop diff page and remove the mobile-specific page. That work is tracked into T117279. Feel free to resolve this as a duplicate of that ticket, but we do not plan to do any further work on the existing diff page. At this time I can't promise any timelines.

I think removing Special:MobileDiff will address this problem; I consider that a perfectly acceptable solution. I hope it will happen soon, but considering how well FlaggedRevs is maintained, any finite amount of time will be sooner than when it’d be worked around on FlaggedRevs side. :)

Sounds good! Thanks for the understanding! Hope we can work something out soon.

Jdlrobson changed the task status from Open to Stalled.Tue, Mar 19, 12:41 AM

But diff page HTML on mobile should be identical to desktop now (T358293)

@Tacsipacsi is this fixed now? I don't think I am setup to review changes as desktop looks same as mobile to me:
ttps://hu.m.wikipedia.org/wiki/Speci%C3%A1lis:Elavult_ellen%C5%91rz%C3%B6tt_lapok

If not let me know what I can do to help by updating the description with clearer replication steps (screenshots would be helpful!). It might be that something is hidden via display: none which shouldn't be.

@Tacsipacsi is this fixed now? I don't think I am setup to review changes as desktop looks same as mobile to me:
ttps://hu.m.wikipedia.org/wiki/Speci%C3%A1lis:Elavult_ellen%C5%91rz%C3%B6tt_lapok

The “review button” is actually a diff link labelled review. Its presence doesn’t depend on any settings or user rights, I see it on https://hu.m.wikipedia.org/wiki/Speci%C3%A1lis:Elavult_ellen%C5%91rz%C3%B6tt_lapok?uselang=en bot logged-in and logged-out. And this part has probably never been broken on mobile.

What’s been broken is the screen that appears when you click/tap the diff link: it used to be Special:MobileDiff, but is now the regular diff view. In the regular diff view, the review box does appear for reviewers (the box labeled Review this revision). The overall diff view doesn’t look great (e.g. the [checked revision] and [pending revision] markers are off – this is kind of the norm in FlaggedRevs), but it’s usable:

Screenshot 2024-03-19 at 13-44-07 Lackner László Difference between revisions - Wikipédia.png (926×1 px, 138 KB)

Jdlrobson claimed this task.

This looks fixed to me then. Agree this could do with some design, but the important thing is this works.