Page MenuHomePhabricator

Echo: Message `apihelp-echomarkread-param-wikis` is missing
Closed, ResolvedPublicBUG REPORT

Description

Steps to reproduce:
Visit https://en.wikipedia.org/w/api.php?action=help&modules=echomarkread
See "⧼apihelp-echomarkread-param-wikis⧽"

The wikis parameter for ApiEchoMarkRead is not defined in ApiEchoMarkRead.php:

parameters
public function getAllowedParams() {
	return $this->getCrossWikiParams() + [
		'list' => [
			ApiBase::PARAM_ISMULTI => true,
		],
		'unreadlist' => [
			ApiBase::PARAM_ISMULTI => true,
		],
		'all' => [
			ApiBase::PARAM_REQUIRED => false,
			ApiBase::PARAM_TYPE => 'boolean'
		],
		'sections' => [
			ApiBase::PARAM_TYPE => EchoAttributeManager::$sections,
			ApiBase::PARAM_ISMULTI => true,
		],
		'token' => [
			ApiBase::PARAM_REQUIRED => true,
		]
	];
}

instead, it is inherited from getCrossWikiParams()

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 changed the subtype of this task from "Task" to "Bug Report".

Change 551614 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/Echo@master] Set apihelp message for wikis parameter

https://gerrit.wikimedia.org/r/551614

Umherirrender triaged this task as Medium priority.

Change 551614 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Set apihelp message for wikis parameter of echomarkread

https://gerrit.wikimedia.org/r/551614