Page MenuHomePhabricator
Create Task
Maniphest T238539

Remove ControlledFallbackEntityIdFormatter and surrounding logic
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

ControlledFallbackEntityIdFormatter was introduced as part of T196882.

It is a "Wrapper class giving ability to replace EntityIdFormatter in production in a controlled manner."

This replacement has now been done and the new code is always called, so the fallback is not needed.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Wikibasemaster+3 -259Drop ControlledFallbackEntityIdFormatter
Customize query in gerrit

Related Objects

Event Timeline

• Addshore created this task.Nov 18 2019, 1:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 18 2019, 1:25 PM
• Addshore triaged this task as Low priority.Nov 18 2019, 1:26 PM
• Addshore moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.
• Addshore mentioned this in T238540: Delete grafana dashboard, https://grafana.wikimedia.org/d/000000599/wikibase-wb_terms-newitemidformatter.Nov 18 2019, 1:28 PM
• Addshore set the point value for this task to 3.Dec 10 2019, 1:24 PM
• Addshore moved this task from Ready to estimate to Ready to pick up on the Wikidata-Campsite board.
• Addshore moved this task from incoming to consider for next sprint on the Wikidata board.Dec 11 2019, 11:47 AM
gerritbot added a comment.Dec 13 2019, 10:15 AM

Change 556985 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Drop ControlledFallbackEntityIdFormatter

https://gerrit.wikimedia.org/r/556985

gerritbot added a project: Patch-For-Review.Dec 13 2019, 10:15 AM
Ladsgroup claimed this task.Dec 13 2019, 10:15 AM
Ladsgroup edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptDec 13 2019, 10:15 AM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 13 2019, 10:15 AM
gerritbot added a comment.Dec 13 2019, 1:24 PM

Change 556985 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Drop ControlledFallbackEntityIdFormatter

https://gerrit.wikimedia.org/r/556985

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.11; 2019-12-17).Dec 13 2019, 2:01 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 13 2019, 2:10 PM
Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 16 2019, 10:40 AM
• Addshore closed this task as Resolved.Dec 23 2019, 1:01 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL