portals/deploy build broken due to a syntax error in stylelint npm module
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	hashar
	Nov 18 2019, 3:44 PM

Description

Since https://gerrit.wikimedia.org/r/#/c/wikimedia/portals/+/548933/
the CI job that generates the /deploy repository is broken: https://integration.wikimedia.org/ci/job/wikimedia-portals-build/139/

00:02:11.644 > gulp -- lint
00:02:11.644 
00:02:12.712 /srv/jenkins-workspace/workspace/wikimedia-portals-build/node_modules/stylelint/lib/utils/checkAgainstRule.js:18
00:02:12.712 ) {
00:02:12.712 ^
00:02:12.712 SyntaxError: Unexpected token )
00:02:12.712     at createScript (vm.js:56:10)

And the npm install output shows:

00:02:11.266 ├── UNMET PEER DEPENDENCY stylelint@^9.6.0
00:02:11.266 ├─┬ stylelint-config-wikimedia@0.7.0 
00:02:11.266 │ └─┬ stylelint@11.1.1

Details

	Subject	Repo	Branch	Lines +/-
	Revert "build: Upgrade various linters for npm audit concerns" This reverts commit 5a166b3e36f70e9330ea1cab3753bd0e787b3bf6.	wikimedia/portals	master	+810 -1 K

Customize query in gerrit

Related Objects

Mentioned In: T238747: Migrate www.wikipedia.org (and other www portals) to be its own service
Mentioned Here: T238747: Migrate www.wikipedia.org (and other www portals) to be its own service
rWPOR5a166b3e36f7: build: Upgrade various linters for npm audit concerns

Event Timeline

hashar created this task.Nov 18 2019, 3:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 18 2019, 3:44 PM

Jdforrester-WMF mentioned this in T238747: Migrate www.wikipedia.org (and other www portals) to be its own service.Nov 20 2019, 2:54 PM

Jdrewniak claimed this task.Nov 25 2019, 1:24 PM

Jdforrester-WMF added a project: Release-Engineering-Team-TODO (201911).Nov 25 2019, 7:19 PM

Change 553080 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[wikimedia/portals@master] Revert "build: Upgrade various linters for npm audit concerns" This reverts commit 5a166b3e36f70e9330ea1cab3753bd0e787b3bf6.

https://gerrit.wikimedia.org/r/553080

gerritbot added a project: Patch-For-Review.Nov 26 2019, 10:52 AM

Change 553080 merged by jenkins-bot:
[wikimedia/portals@master] Revert "build: Upgrade various linters for npm audit concerns" This reverts commit 5a166b3e36f70e9330ea1cab3753bd0e787b3bf6.

https://gerrit.wikimedia.org/r/553080

I tried to update the peer dependencies, but this led to the following error when building a binary with node-gyp :/ so I think a revert is in order here.

warning: include path for stdlibc++ headers not found; pass '-stdlib=libc++' on the command line to use the libc++ standard library instead [-Wstdlibcxx-not-found]
In file included from ../src/common/allocator.cc:1:
In file included from ../../nan/nan.h:54:
In file included from /Users/jdrewniak/.node-gyp/6.14.4/include/node/node.h:42:
/Users/jdrewniak/.node-gyp/6.14.4/include/node/v8.h:21:10: fatal error: 'utility' file not found
#include <utility>
         ^~~~~~~~~
1 warning and 1 error generated.
make: *** [Release/obj.target/iltorb/src/common/allocator.o] Error 1

The revert is just a workaround, but that fixed https://integration.wikimedia.org/ci/job/wikimedia-portals-build/ and generated

https://gerrit.wikimedia.org/r/#/c/wikimedia/portals/deploy/+/553082 Assets build - 2019-11-26 10:59:18+00:00

@Jdrewniak , @thcipriani and I talked about the situation last week. Seems the best fix long term is to switch to the release pipeline and ultimately have the portals served from Kubernetes. T238747: Migrate www.wikipedia.org (and other www portals) to be its own service

Maintenance_bot removed a project: Patch-For-Review.Nov 26 2019, 11:30 AM

hashar closed this task as Resolved.Nov 26 2019, 11:55 AM

portals/deploy build broken due to a syntax error in stylelint npm moduleClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

portals/deploy build broken due to a syntax error in stylelint npm module
Closed, ResolvedPublic
Actions