Wikidata Beta returns a stack trace
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tarrow
	Nov 18 2019, 8:19 PM

Description

Both the Main page and Entities return a stack trace of the following form:

MediaWiki internal error.

Original exception: [XdL8WKwQBHcAACSDdKQAAAAX] /wiki/Property:P2 MWException from line 164 of /srv/mediawiki/php-master/includes/Hooks.php: Invalid callback WikidataOrg\Hooks::onBeforePageDisplay in hooks for BeforePageDisplay

Backtrace:
#0 /srv/mediawiki/php-master/includes/Hooks.php(234): Hooks::callHook(string, array, array, NULL, string)
#1 /srv/mediawiki/php-master/includes/OutputPage.php(2623): Hooks::runWithoutAbort(string, array)
#2 /srv/mediawiki/php-master/includes/MediaWiki.php(974): OutputPage->output(boolean)
#3 /srv/mediawiki/php-master/includes/MediaWiki.php(987): MediaWiki->{closure}()
#4 /srv/mediawiki/php-master/includes/MediaWiki.php(530): MediaWiki->main()
#5 /srv/mediawiki/php-master/index.php(46): MediaWiki->run()
#6 /srv/mediawiki/w/index.php(3): require(string)
#7 {main}

Exception caught inside exception handler: [XdL8WKwQBHcAACSDdKQAAAAX] /wiki/Property:P2 MWException from line 164 of /srv/mediawiki/php-master/includes/Hooks.php: Invalid callback WikidataOrg\Hooks::onBeforePageDisplay in hooks for BeforePageDisplay

Backtrace:
#0 /srv/mediawiki/php-master/includes/Hooks.php(234): Hooks::callHook(string, array, array, NULL, string)
#1 /srv/mediawiki/php-master/includes/OutputPage.php(2623): Hooks::runWithoutAbort(string, array)
#2 /srv/mediawiki/php-master/includes/exception/MWException.php(180): OutputPage->output()
#3 /srv/mediawiki/php-master/includes/exception/MWException.php(216): MWException->reportHTML()
#4 /srv/mediawiki/php-master/includes/exception/MWExceptionHandler.php(101): MWException->report()
#5 /srv/mediawiki/php-master/includes/exception/MWExceptionHandler.php(177): MWExceptionHandler::report(MWException)
#6 /srv/mediawiki/php-master/includes/MediaWiki.php(563): MWExceptionHandler::handleException(MWException)
#7 /srv/mediawiki/php-master/index.php(46): MediaWiki->run()
#8 /srv/mediawiki/w/index.php(3): require(string)
#9 {main}

Details

Subject	Repo	Branch	Lines +/-
Switch from load_composer_autoloader AutoloadNamespaces	mediawiki/extensions/Wikidata.org	wmf/1.35.0-wmf.5	+3 -1
Switch from load_composer_autoloader AutoloadNamespaces	mediawiki/extensions/Wikidata.org	master	+3 -1
Revert "Add WDQS lag into request maxlag logic."	mediawiki/extensions/Wikidata.org	master	+3 -679

Customize query in gerrit

Related Objects

Mentioned Here: T221774: Add Wikidata query service lag to Wikidata maxlag

Event Timeline

Tarrow created this task.Nov 18 2019, 8:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 18 2019, 8:19 PM

Sounds like this is me..

Restricted Application added a project: User-Addshore. · View Herald TranscriptNov 18 2019, 8:20 PM

Pinging @Lucas_Werkmeister_WMDE since he has the incident manager mug

Change 551637 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikidata.org@master] Revert "Add WDQS lag into request maxlag logic."

https://gerrit.wikimedia.org/r/551637

gerritbot added a project: Patch-For-Review.Nov 18 2019, 8:24 PM

Caused by https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikidata.org/+/532495/ from T221774

Addshore moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 18 2019, 8:28 PM

The offending patch just got reverted. It takes some time to take into effect but it should be fixed now.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptNov 18 2019, 8:30 PM

People are really fast here :D

Change 551640 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikidata.org@master] Switch from load_composer_autoloader AutoloadNamespaces

https://gerrit.wikimedia.org/r/551640

Change 551637 abandoned by Ladsgroup:
Revert "Add WDQS lag into request maxlag logic."

Reason:
Done in a better way

https://gerrit.wikimedia.org/r/551637

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Nov 18 2019, 9:15 PM

Maintenance_bot moved this task from Incoming to In progress on the User-Ladsgroup board.

Change 551640 merged by jenkins-bot:
[mediawiki/extensions/Wikidata.org@master] Switch from load_composer_autoloader AutoloadNamespaces

https://gerrit.wikimedia.org/r/551640

Thanks @Addshore. That's the fix :)

Maintenance_bot removed a project: Patch-For-Review.Nov 18 2019, 10:10 PM

Maintenance_bot moved this task from In progress to Done on the User-Ladsgroup board.Nov 18 2019, 10:15 PM

Change 551856 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikidata.org@wmf/1.35.0-wmf.5] Switch from load_composer_autoloader AutoloadNamespaces

https://gerrit.wikimedia.org/r/551856

gerritbot added a project: Patch-For-Review.Nov 19 2019, 3:57 PM

Change 551856 merged by jenkins-bot:
[mediawiki/extensions/Wikidata.org@wmf/1.35.0-wmf.5] Switch from load_composer_autoloader AutoloadNamespaces