Page MenuHomePhabricator

Spike: test new parsoid html with mobile
Closed, InvalidPublicSpike

Description

Questions

  • does it work in mobile out the box
  • Is there anything we can drop in the mobileformatter e.g. section wrapping?
  • is there anything in js/css that might break?
  • any styles missing due to different html / missing styles?

Event Timeline

Restricted Application changed the subtype of this task from "Task" to "Spike". · View Herald TranscriptNov 19 2019, 4:34 PM

@Jdlrobson is this a blocker for turning on Parsoid/PHP everywhere? Or is this a new thing you are trying out with Parsoid/PHP?

@ssastry just saw your email and figured we should test things in MobileFrontend. Unless that's been done?

I am a bit confused though as I thought Parsoid HTML had section tags but I am not seeing one anywhere on the test wikis...

@ssastry just saw your email and figured we should test things in MobileFrontend. Unless that's been done?

No, I somehow missed that MobileFrontend uses Parsoid HTML. Otherwise, I would have created the ticket for it as well just like I created ones for the other Parsoid clients (VE, CX, Flow, MCS). So, no it hasn't been done.

I am a bit confused though as I thought Parsoid HTML had section tags but I am not seeing one anywhere on the test wikis...

It should. Let me go look later today and I'll report back.

I am a bit confused though as I thought Parsoid HTML had section tags but I am not seeing one anywhere on the test wikis...

While debugging T238665: Dirty diff on test.wikipedia.org I had to dump output for a page on testwiki, and T238665#5676610 and the following comment shows that section tags do exist. Can you let me know how I can reproduce what you are finding (about missing section tags)?

Just to be clear, Parsoid/PHP only replaces Parsoid/JS. It doesn't replace Parser.php, the core/legacy parser yet. So, all read views continue to be served by Parser.php output.

Ah got it! I thought this was replacing Parser.php.

Sorry for the confusion in terminology but bear us in mind if you'd like guinea pigs (mobile site html) to switch to Parsoid HTML in the future!

Jdlrobson closed this task as Invalid.Nov 20 2019, 12:42 AM

Misunderstanding