Page MenuHomePhabricator

CI failing with “Return value of MediaWikiServices::getStatsdDataFactory() must implement IBufferingStatsdDataFactory, instance of Mock_StatsdDataFactory_5d2038b7 returned”
Closed, ResolvedPublic

Description

10:26:05 1) AuthManagerStatsdHandlerTest::testHandle with data set "right channel" (array('authevents', array('autocreate')), 'authmanager.autocreate')
10:26:05 === Logs generated by test case
10:26:05 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:26:05 [localisation] [debug] LocalisationCache: using store LCStoreNull []
10:26:05 ===
10:26:05 TypeError: Return value of MediaWiki\MediaWikiServices::getStatsdDataFactory() must implement interface IBufferingStatsdDataFactory, instance of Mock_StatsdDataFactory_5d2038b7 returned
10:26:05 
10:26:05 /workspace/src/includes/MediaWikiServices.php:1084
10:26:05 /workspace/src/extensions/WikimediaEvents/includes/AuthManagerStatsdHandler.php:97
10:26:05 /workspace/src/extensions/WikimediaEvents/tests/phpunit/AuthManagerStatsdHandlerTest.php:25
10:26:05 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:417
10:26:05 /workspace/src/maintenance/doMaintenance.php:99

Affected repositories:

Details

Related Gerrit Patches:
mediawiki/extensions/WikimediaEvents : masterMock correct interface in AuthManagerStatsdHandlerTest
mediawiki/extensions/WikimediaEvents : masterDNM: no-op change to test CI

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 20 2019, 9:58 AM

Change 552026 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikimediaEvents@master] DNM: no-op change to test CI

https://gerrit.wikimedia.org/r/552026

Lucas_Werkmeister_WMDE triaged this task as Unbreak Now! priority.Nov 20 2019, 10:03 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)

Affects multiple repositories ⇒ UBN!

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptNov 20 2019, 10:03 AM

The mock may have been incorrect before (I think MediaWikiServices::getStatsdDataFactory has been documented to return an IBufferingStatsdDataFactory, not a StatsdDataFactoryInterface or StatsdDataFactory, for a while), but it looks like this is only a PHP error since the return type declaration was added in I28aea9a95e, so CC @Mooeypoo, @Jdforrester-WMF, @Reedy.

Change 552028 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikimediaEvents@master] Mock correct interface in AuthManagerStatsdHandlerTest

https://gerrit.wikimedia.org/r/552028

Change 552026 abandoned by Lucas Werkmeister (WMDE):
DNM: no-op change to test CI

https://gerrit.wikimedia.org/r/552026

Restricted Application added a project: Wikidata. · View Herald TranscriptNov 20 2019, 10:17 AM

Change 552028 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] Mock correct interface in AuthManagerStatsdHandlerTest

https://gerrit.wikimedia.org/r/552028

Lucas_Werkmeister_WMDE lowered the priority of this task from Unbreak Now! to High.Nov 20 2019, 10:22 AM

Tentatively lowering priority, since this is hopefully fixed (currently waiting on gate-and-submit for the Wikibase build linked in the task description to verify).

Thank you for fixing this!