CI failing with “Return value of MediaWikiServices::getStatsdDataFactory() must implement IBufferingStatsdDataFactory, instance of Mock_StatsdDataFactory_5d2038b7 returned”
Closed, ResolvedPublic
Actions

Description

10:26:05 1) AuthManagerStatsdHandlerTest::testHandle with data set "right channel" (array('authevents', array('autocreate')), 'authmanager.autocreate')
10:26:05 === Logs generated by test case
10:26:05 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
10:26:05 [localisation] [debug] LocalisationCache: using store LCStoreNull []
10:26:05 ===
10:26:05 TypeError: Return value of MediaWiki\MediaWikiServices::getStatsdDataFactory() must implement interface IBufferingStatsdDataFactory, instance of Mock_StatsdDataFactory_5d2038b7 returned
10:26:05 
10:26:05 /workspace/src/includes/MediaWikiServices.php:1084
10:26:05 /workspace/src/extensions/WikimediaEvents/includes/AuthManagerStatsdHandler.php:97
10:26:05 /workspace/src/extensions/WikimediaEvents/tests/phpunit/AuthManagerStatsdHandlerTest.php:25
10:26:05 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:417
10:26:05 /workspace/src/maintenance/doMaintenance.php:99

Affected repositories:

Wikibase (example change, build)
WikimediaEvents (example change, build)

Details

	Subject	Repo	Branch	Lines +/-
	Mock correct interface in AuthManagerStatsdHandlerTest	mediawiki/extensions/WikimediaEvents	master	+1 -3
	DNM: no-op change to test CI	mediawiki/extensions/WikimediaEvents	master	+0 -0

Customize query in gerrit

Event Timeline

Lucas_Werkmeister_WMDE created this task.Nov 20 2019, 9:58 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 20 2019, 9:58 AM

Change 552026 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikimediaEvents@master] DNM: no-op change to test CI

https://gerrit.wikimedia.org/r/552026

gerritbot added a project: Patch-For-Review.Nov 20 2019, 10:00 AM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Nov 20 2019, 10:00 AM

Affects multiple repositories ⇒ UBN!

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptNov 20 2019, 10:03 AM

WMDE-leszek subscribed.Nov 20 2019, 10:05 AM

The mock may have been incorrect before (I think MediaWikiServices::getStatsdDataFactory has been documented to return an IBufferingStatsdDataFactory, not a StatsdDataFactoryInterface or StatsdDataFactory, for a while), but it looks like this is only a PHP error since the return type declaration was added in I28aea9a95e, so CC @Mooeypoo, @Jdforrester-WMF, @Reedy.

Ladsgroup added a project: MediaWiki-extensions-WikimediaEvents.Nov 20 2019, 10:09 AM

Ladsgroup subscribed.

Change 552028 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikimediaEvents@master] Mock correct interface in AuthManagerStatsdHandlerTest

https://gerrit.wikimedia.org/r/552028

Change 552026 abandoned by Lucas Werkmeister (WMDE):
DNM: no-op change to test CI

https://gerrit.wikimedia.org/r/552026

Lucas_Werkmeister_WMDE added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Nov 20 2019, 10:17 AM

Restricted Application added a project: Wikidata. · View Herald TranscriptNov 20 2019, 10:17 AM

Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 20 2019, 10:17 AM

Change 552028 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] Mock correct interface in AuthManagerStatsdHandlerTest

https://gerrit.wikimedia.org/r/552028

Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 20 2019, 10:19 AM

Tentatively lowering priority, since this is hopefully fixed (currently waiting on gate-and-submit for the Wikibase build linked in the task description to verify).

Lucas_Werkmeister_WMDE closed this task as Resolved.Nov 20 2019, 10:36 AM

Lucas_Werkmeister_WMDE claimed this task.

Lucas_Werkmeister_WMDE moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Lucas_Werkmeister_WMDE moved this task from Untriaged to Resolved on the Wikimedia-production-error (ARCHIVED -- Shared Build Failure) board.

Lucas_Werkmeister_WMDE moved this task from incoming to in progress on the Wikidata board.Nov 20 2019, 10:40 AM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 20 2019, 11:00 AM

Maintenance_bot removed a project: Patch-For-Review.Nov 20 2019, 11:10 AM