Page MenuHomePhabricator

First Batch of TY Emails Pushed to Gerritt
Closed, ResolvedPublic

Description

Hi Yall!

I pushed FR, NL, and NB TY Email templates to Gerritt.
Ready to be set to staging!
Please let me know when I can send myself test emails from civi :)

Thanks,
Camille

Event Timeline

Hi Camille

We've pushed the latest updates from this patch to staging for you to test.

While testing the updates on staging, we noticed that a question mark was wrapping when reducing the browser window down to half the screen size, see snapshot here

fr_ty_letter (446×607 px, 81 KB)

Let us know if you're happy with it or if you need to make changes update the patch and we can redeploy to staging. If all is ok we can deploy it to live as is!

Thanks!

Hi Camille, these are back up on staging. I just sent you test versions of each of them.

Thank you, Elliott! I see there are some unnecessary, extra line breaks in
the signature between Katherine and Katherine Maher. I'll need to make
those edits tomorrow.

These are up on staging, and I just sent tests with recurring flag set to cdenes@

Did the versions sent on Jan 7th look good? I don't see any obvious errors looking at the patch.

Thank you for following up Elliott! Apologies for the delay. I will have our translation reviewers proof the test emails, and I will confirm when ready to be pushed to production.

Hi yall!

Checking in with some edits to French email. I am, unfortunately, working from a loaner laptop and my machine isn't set up to make edits to files in staging (tomorrow I should have my laptop back, albeit wiped). Anyways, would it be possible if I simply communicate edits on here? Please let me know, if so, two small edits to the French email:

  1. Could we put those 2 paragraphs together to just have 1? the flow is really off otherwise

"Après des années à travailler pour la Wikimedia Foundation, j'ai fini par réaliser qu'il existe une infinité de manières de vivre, de lire et d'aimer Wikipédia. Sa beauté, c'est justement que chacun se l'approprie comme il veut.

La prochaine fois que vous utiliserez Wikipédia, j'espère que vous aussi vous ressentirez combien elle vous appartient. Parce que sans vous et sans le soutien des millions de personnes qui sont sur Wikipédia chaque jour, nous n'existerions tout simplement pas."

  1. At the bottom, it says "with gratitude, Katherine" and then right below you have "katherine Maher, executive director ..etc.". Let's just have one signature "With gratitude, Katherine Maher, executive director etc.

I made these changes on staging but as a note, I just made a local commit on frdev and updated the original patch because git fetch wasn't working...

Hi all

A) French email
Email on staging looks good-- approved on my end for production

B) Dutch email
ERROR 1: Currency symbol should come after the amount
ERROR 2: In the phrase "...volg dan dezeeenvoudige annuleringsinstructies.." There is a duplicate period at the end of the sentence
ERROR 3: In the phrase "...volg dan dezeeenvoudige annuleringsinstructies.." the hyperlink should be on the text <dezeeenvoudige annuleringsinstructies>
ERROR 4: REMOVE this sentence "Hoe manifesteert uw nieuwsgierigheid zich? Speelt Wikipedia hier een rol in? "
EDIT 5: Please *bold* this sentence "Uw donatie geeft kracht en stelt ons in staat om onze missie te vervullen. Bedankt dat u ruimte voor Wikipedia in uw leven heeft gemaakt."

C) Norwegian email
Email on staging looks good-- approved on my end for production

Just as FYI we need all three of these in production for the Big Bundle campaign. Main campaign launch is March 17th. Thank you!

Camille

@CDenes, we're getting our currency symbol placement from the CLDR library, a collection of standards for formatting things in different languages. It's got the NL standard as e.g. € 1,23 for 1.23 euros. Is that really not how things are written in the Netherlands?

dezeeenvoudige looked weird to me because of the triple 'e', so I googled it. All the results have it as two words, "deze eenvoudige". Should I just add a space before the link then, and leave just "eenvoudige annuleringsinstructies" linked?

Oops, @CDenes_WMF, I meant to tag you in the above two comments

The version with fixes for errors 2, 3 (but as two separate words), 4, & 5 is up on staging. I haven't put in any hacks to change currency formatting from the CLDR standards.

Hi @Ejegg !
The currency format standard I checked against is here https://www.paymotion.com/ecommerce-blog/how-to-format-prices-in-different-countries/ BUT definitely not the end-all; I noticed there's genuinely a lot of contradicting info depending on where you get the standards from; so I am super happy to keep using the CLDR standards that you have used in the past. Would you please be able to share so I can refer to it for future campaigns and also share with our QA specialist John?

RE "dezeeenvoudige looked weird to me because of the triple 'e', so I googled it. All the results have it as two words, "deze eenvoudige". Should I just add a space before the link then, and leave just "eenvoudige annuleringsinstructies" linked? " Yes I think that sounds OK to add a space before after "deze" and leave the hyperlinked as-is. Thank you!!!

Here's a bit that refers to CLDR and specifically talks about Dutch currency standards: http://www.bubblefoundry.com/blog/2013/11/formatting-dutch-currency-amounts/

The CLDR project itself is part of the Unicode Consortium (best known as the people that define new emojis, but they are loved by programmers the world over for giving us one consistent way to read and write text files no matter the alphabet). The project's website is here: http://cldr.unicode.org/

For some corroboration, here's a Microsoft currency formatting page that happens to use Dutch as an example, and puts the euro symbol first: https://docs.microsoft.com/en-us/globalization/locale/currency-formatting

I notice that in CLDR, nl_BE is formatted with the currency symbol after. Maybe the person that wrote the paymotion post was more familiar with Dutch as written in Belgium?

It could be! Either way, I am super happy to adhere to this CLDR standard. Thank you for forwarding the documentation :)

jgleeson subscribed.