Page MenuHomePhabricator
Create Task
Maniphest T238737

Upgrade NPM / TypeScript packages on Laika skin and fix issues in code
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

When updating the NPM packages, I ran into TypeScript-related issues, specifically in the various SubmitValues.vue files which make use of mapState.

I am not entirely sure what is causing these new linting issues to appear but it seems to be related to the TypeScript packages and linting packages. The code appears to be working fine as before, but we will likely need to refactor all SubmitValues.vue files when updating the NPM packages the next time.

Acceptance criteria:

package.lock file can be deleted and updated with make update-js without creating any linting / code errors.

Related Objects
Search...

Event Timeline

• Tim_WMDE created this task.Nov 20 2019, 1:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 20 2019, 1:09 PM
• Tim_WMDE set the point value for this task to 3.Nov 20 2019, 1:10 PM
• Tim_WMDE moved this task from Backlog to Sprint ready on the WMDE-Fundraising-Tech board.
• Tim_WMDE added a subscriber: gabriel-wmde.Nov 20 2019, 1:15 PM
gabriel-wmde mentioned this in T241851: Investigate how to speed up the Laika build process.Jan 3 2020, 5:41 PM
gabriel-wmde triaged this task as High priority.Feb 14 2020, 5:30 PM
gabriel-wmde added a parent task: T205707: Modernize FundraisingFrontend JavaScript.
gabriel-wmde added a project: WMDE-Fundraising-CFR.
gabriel-wmde moved this task from Backlog to Sprint Ready on the WMDE-Fundraising-CFR board.
kai.nissen added a project: WMDE-FUN-Sprint-2020-03-02.Mar 2 2020, 12:51 PM
gabriel-wmde moved this task from Todo to Doing on the WMDE-FUN-Sprint-2020-03-02 board.Mar 3 2020, 8:55 AM
gabriel-wmde moved this task from Doing to Review on the WMDE-FUN-Sprint-2020-03-02 board.Mar 3 2020, 4:47 PM

Pull request is here: https://github.com/wmde/FundraisingFrontend/pull/1701

The fix for the type errors is does not decrease type safety (since types for the parameters were not checked against the store model) but look ugly. I've asked a question on StackOverflow on how to implement it better: https://stackoverflow.com/q/60510684/130121
But please still review & merge the PR.

I've created a CFR task for collecting ideas on how to improve type safety of our state management: T246798: Use Pinia for state handling

gabriel-wmde moved this task from Review to Deploy on the WMDE-FUN-Sprint-2020-03-02 board.Mar 4 2020, 10:12 AM
gabriel-wmde moved this task from Deploy to Done on the WMDE-FUN-Sprint-2020-03-02 board.Mar 12 2020, 2:35 PM
kai.nissen moved this task from Sprint ready to Current Sprint on the WMDE-Fundraising-Tech board.Mar 13 2020, 11:04 AM
kai.nissen closed this task as Resolved.Mar 16 2020, 11:41 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL