Page MenuHomePhabricator

CU 2.0: Display data in the Compare tab
Open, MediumPublic2 Estimate Story Points

Description

Goal

This task is for displaying the information we fetch for the Compare tab in T238714: CU 2.0: Fetch information to be displayed in Compare tab.

Acceptance criteria

Mock: https://prtksxna.github.io/wmf-cu-prototype/compare.html
The information is placed in one table like the one in the Epic ticket:

UsernameActivityIPUser-agent
ApplesAugust 12, 11:00 - September 13, 10:001.2.3.4 - 17 edits (10 from 3 other users)Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1 Safari/605.1.15
ApplesAugust 16, 13:00 - September 1, 8:001.5.6.4 - 123 edits (1560 from 35 other users)Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1 Safari/605.1.15
BananasAugust 12, 11:00 - September 13, 10:001.2.3.4 - 17 edits (10 from 3 other users)Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1 Safari/605.1.15
BananasAugust 16, 13:00 - September 1, 8:001.5.6.4 - 123 edits (1560 from 35 other users)Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1 Safari/605.1.15
GrapesAugust 12, 11:00 - September 13, 10:00 1.5.6.7 - 17 editsMozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1 Safari/605.1.15
UnregisteredAugust 16, 13:00 - September 1, 8:00 1.5.6.7 - 123 editsMozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1 Safari/605.1.15
PineapplesAugust 12, 11:00 - September 13, 10:00 1.9.8.4 - 17 editsMozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1 Safari/605.1.15
UnregisteredAugust 16, 13:00 - September 1, 8:00 1.9.8.4 - 123 editsMozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1 Safari/605.1.15
Things to note:
  • There is a new tab next to Preliminary check for Compare (need to come up with a better name though).
  • In the initial load, rows are grouped by username, followed by IP address (for different UAs). If an IP and associated username were both looked up, club the row with the username.
  • Include option to sort in the Username, IP address and User-agent column headers. We'll make the sorting actually work in a separate task.
  • There is a visual indicator to distinguish the usernames and IPs explicitly entered by the user. Needs a mock
  • There is a link/button for the (10 from 3 other users) information that would allow the user to click it and add the new rows to the table. We'll add the functionality to actually append the new rows in a follow-up ticket. Needs a mock

Event Timeline

Niharika created this task.Nov 20 2019, 7:07 PM
Niharika moved this task from Untriaged to Design on the Anti-Harassment board.

@Prtksxna Putting this in your column for the couple mocks needed.

Niharika assigned this task to Prtksxna.Nov 20 2019, 8:10 PM
Niharika triaged this task as Medium priority.
Niharika updated the task description. (Show Details)Nov 21 2019, 5:24 PM
Niharika set the point value for this task to 2.Nov 21 2019, 5:29 PM
Prtksxna added a comment.EditedSun, Dec 29, 6:52 PM

The IP column currently has four pieces of information:

  • IP
  • Number of edits by this user using the IP
  • Total number of users using this IP
  • Total number of edits using this IP

Since

  1. the CheckUser might want to sort on some of these fields and
  2. this column is currently overloaded and a bit confusing…

We're going to split this column into four — https://prtksxna.github.io/wmf-cu-prototype/compare.html

I am not happy with the column header labels though, too long.

@Prtksxna or @Niharika is "Edits using this IP" the "Public" IP edits or is it the "Total" edits from that IP (Public and Logged-in Users)?

@Prtksxna or @Niharika is "Edits using this IP" the "Public" IP edits or is it the "Total" edits from that IP (Public and Logged-in Users)?

I think the latter (based on the comments in T238714) . And it should include the the edits made by the current (as in current row) user too. This time, I have tried to make the numbers on the prototype add up correctly to get a feel for it and I think it's making sense. What do you think @Niharika?

Yeah, I think it should be the Total edits as well.

AronManning added a comment.EditedThu, Jan 9, 1:22 AM

@Niharika for effectively using the checkuser it would be important to also present the subnet/ISP the IP belongs to (related T174553). I've suggested adding this to the design 2 months ago in T237593#5643299, but there was no discussion about it since then. I reckon if this is not done now with the fundamental design work, then it won't be done in the coming years. This is the best time to make that part of the design.

With secondary importance presenting the Tor/VPN/proxy likelihood would be a similar task, the two could be done together.

@Prtksxna I've updated the two patches for the mock-up from 2 months ago that you could merge: a layout fix, a missing </div> and adding "vpn check" to the IP tools.

SQL added a subscriber: SQL.Tue, Jan 14, 5:00 PM
AronManning added a comment.EditedFri, Jan 17, 2:12 AM

@Prtksxna have you looked at the patches I've submitted? Those are fairly trivial, should take long to review. Is there something wrong with it?