We can expect the returned resultset for the Preliminary check and Compare tabs to be fairly large so we should paginate the results. Filters, highlights, sorting will need to work across the paginated tabs/results. In our estimation meeting we decided to go with server-side pagination for now and iterate to build client-side pagination if we feel we need it.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add compare tab to Special:Investigate | mediawiki/extensions/CheckUser | master | +279 -5 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T139810 RFC: Overhaul the CheckUser extension | |||
| Open | • Niharika | T236225 [Epic] CheckUser 2.0 Improvements | |||
| Open | • Niharika | T237593 [Epic] CheckUser 2.0: Compare | |||
| Resolved | dmaza | T238808 CU 2.0: Pagination in the compare tab |
Change 571626 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/extensions/CheckUser@master] Add compare tab to Special:Investigate
Change 571626 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Add compare tab to Special:Investigate
@Niharika The default limit is decided by user preferences in Special:Preferences > Recent changes. We could override that default - is the 100 figure important?
- Results in the compare tab appear paginated with the highlights, filters and sorting working as selected by the user
Obviously there is no highlighting, filtering etc. to test yet.
But, I could test the pagination functionality on preliminary check and compare and that all the correct rows are returned (nothing missing or duplicated across pages).
You are not always going to get the full number of rows on each page if, for example, the last page less rows than the limit. Similarly, if you click "Last page" and click through "Previous page" until you get to the first page, you may have less than the limit.
Version: MediaWiki 1.35.0-alpha (7deb1cf), CheckUser 2.5 (fc9c7f5) 08:38, 21 February 2020 (this is the version with David's latest, not yet merged, patch T239680#5881677. I wanted to test the very latest version as I believe the tokens are part of how the pagination works).
Thanks @dom_walden
You are not always going to get the full number of rows on each page if, for example, the last page less rows than the limit. Similarly, if you click "Last page" and click through "Previous page" until you get to the first page, you may have less than the limit.
Just noting for posterity that this is an oddity of the IndexPager in general.