Page MenuHomePhabricator

CU 2.0: Filters in the Compare tab
Open, MediumPublic3 Estimate Story Points

Description

Goal

We're introducing some filters in the Compare tab to allow users to be able to narrow down the search results and find patterns in the data.

Mock

https://prtksxna.github.io/wmf-cu-prototype/compare.html

Acceptance criteria

To begin with, we'll have one filters in the UI -

  1. Hide the following users or IPs
    • When a username or IP address is being typed in this field, it suggests auto-complete suggestions from the users table.
    • The username/IP picked appears as a pill in the widget.
    • If a user enters a username or IP that is not in the table below, the capsule is red:
    • As soon as a valid username or IP address is entered or the user picks a suggestion from the auto-complete suggester, the result set re-computes to exclude all rows concerning the users or IPs picked by the user.

Event Timeline

Niharika triaged this task as Medium priority.Nov 21 2019, 1:52 AM
Niharika created this task.
Niharika moved this task from Untriaged to Cards ready to be discussed on the Anti-Harassment board.
Prtksxna added a comment.EditedNov 21 2019, 1:09 PM
From the description:

@Prtksxna should we give an error indicator perhaps?

Yeah, we can make the invalid capsules' text red. Similar to the categories input in Upload Wizard (though that is a redlink):


The other option would be to not let them enter an incorrect input, and don't convert it into a capsule:

Is this a validation we can run? If so I'd prefer we do this.

Niharika updated the task description. (Show Details)Dec 10 2019, 7:27 PM
Niharika updated the task description. (Show Details)Dec 10 2019, 7:32 PM

Taking this out for now, per our estimation meeting:

  1. Hide the following user-agents
    • When a user-agent is being typed in this field, it suggests auto-complete suggestions from the users and IPs in the table below.
    • If a user enters a user-agent that is not in the table below, nothing happens. @Prtksxna should we give an error indicator perhaps?
    • As soon as a valid user-agent is entered or the user picks a suggestion from the auto-complete suggester, the result set re-computes to exclude all rows concerning the users or IPs picked by the user.
    • The user-agent picked appears as a pill in the widget.

We can discuss this once we've figured out how we want to break down the UA and change the database accordingly.

@Prtksxna We should update this ticket after we split the form out.

@Niharika, based on the information on each page this how I am thinking of splitting the filters

CompareTimeline
User / IPUser / IP
User AgentUser Agent
Page
Type of activity

Does that sound alright?

@Niharika, based on the information on each page this how I am thinking of splitting the filters

CompareTimeline
User / IPUser / IP
User AgentUser Agent
Page
Type of activity

Does that sound alright?

Whoops, I missed this. Yes, this sounds about right.

Niharika updated the task description. (Show Details)Thu, Jan 9, 6:42 PM
Niharika updated the task description. (Show Details)Thu, Jan 9, 7:44 PM
Niharika updated the task description. (Show Details)
Niharika updated the task description. (Show Details)Thu, Jan 9, 7:49 PM
Niharika set the point value for this task to 3.Thu, Jan 9, 7:52 PM