Page MenuHomePhabricator

Punchlist for SE v3 post-release cleanup
Open, MediumPublic

Description

These issues don't affect things enough to halt the release, but for our minor fundraising release after Thanksgiving, please:

  • Double the length of time the post-login notification toast persists
  • Change the explanatory string about the streak to "How many days without a break you’ve contributed via Suggested edits. If you haven’t contributed in a while, it shows your last contribution date."
  • Investigate why the all-time edits number seems to be incorrect for some accounts.
  • Change edit quality tooltip string to "Based on how many times one of your contributions was reverted (undone by another editor). Reverted edits: %number."

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 21 2019, 4:59 PM
Dbrant updated the task description. (Show Details)Nov 21 2019, 7:12 PM
Charlotte triaged this task as Medium priority.Nov 21 2019, 9:38 PM
Charlotte updated the task description. (Show Details)
  • Change the explanatory string about the streak to "How many days without a break you've contributed using Suggested edits. If you haven't edited in a while, the date of the last edit you made is displayed." (@schoenbaechler may be able to think of something shorter/nicer.)

How about this @Charlotte? (keeping it simple) 👇

How many days without break or the last time you’ve contributed using Suggested edits.

@Charlotte Re:

  • Note in the explanatory string for number of edits that this is edits within the past 30 days.

Are you referring to Contributions (Your total number of contributions with Suggested edits) in the profile stats section? I didn’t know that this total is limited to only show contributions within the past 30 days...

@Charlotte Re:

  • Note in the explanatory string for number of edits that this is edits within the past 30 days.

Are you referring to Contributions (Your total number of contributions with Suggested edits) in the profile stats section? I didn’t know that this total is limited to only show contributions within the past 30 days...

That seems to be what it's showing. @JKatzWMF confirmed it seems to show a lower number of SE edits than he has made in total - 5 edits shown, though obviously more than that having been made in total. It would be good if @Dbrant could verify. (Granted, the original specification was for all-time edits, so I understand your confusion Robin.)

Also if we say "How many days without break or the last time you’ve contributed using Suggested edits" it's a bit confusing to users why we would show one rather than the other.

The number of contributions is the total number of contributions, not just within 30 days. I believe the "30 days" number only applies to the pageviews of items that you've edited.

Also if we say "How many days without break or the last time you’ve contributed using Suggested edits" it's a bit confusing to users why we would show one rather than the other.

@Charlotte I like your suggestion in Revised Suggested edits FAQ:

How many days without a break you’ve contributed via Suggested edits. If you haven’t contributed in a while, it shows your last contribution date.

Also this, as you’re solving one of the usability test issues (revert copy wasn’t understood):

Based on how many times one of your contributions was reverted (that is: undone by another editor). Reverted edits: %number.


@Dbrant as the tooltip copy above is longer, can we increase SE tooltip duration appearance to 8 seconds? I assume that it’s currently around 5 seconds.

The number of contributions is the total number of contributions, not just within 30 days. I believe the "30 days" number only applies to the pageviews of items that you've edited.

Hm. Then we should separately look into why some SE edits seem to be "missing" in the counts for some accounts.

Cheers @schoenbaechler - let's go with that copy then. I will update the task at the top.

Charlotte updated the task description. (Show Details)Nov 22 2019, 4:19 PM
Charlotte updated the task description. (Show Details)
Dbrant updated the task description. (Show Details)Nov 22 2019, 10:09 PM

Thanks for fixing the stuff in the task’s description @Dbrant. I noticed some first time experience issues, all the things below are recorded in this video:

https://www.dropbox.com/s/dno5uu6r46c4nqm/20191126_115320.mp4?dl=0

01) “Reading lists synced successfully“ message and SE snackbar overlap, can we sequence this? Show list sync message after snackbar apperance.

02) Snackbar currently disappears instantly when “History” is accessed. This should not be the case. Also, there’s some odd behavior when accessing “Settings” – after navigating to “Settings“ and tapping the app back button, both the SE snackbar and reading list sync message show up again.

03) Outer background circle of the pulse animation is cut off. This is likely to the changes we’ve made to navigation behavior. Can we make both the inner and outer circle a tad smaller so it’s not cropped?