Page MenuHomePhabricator

Wikibase's Special:EntityData should not emit when responding with HTTP code 304
Closed, ResolvedPublic

Description

As discovered in T237319, when responding with HTTP 304, the response of Special:EntityData contains body, which against HTTP specification.
nginx does seem to have problem handling this non-standard behaviour, which in turn bubbles up to issues at ATS level.

Acceptance criteria:

  • When Special:EntityData response with HTTP status code 304, response body should not be set

Details

Related Gerrit Patches:

Event Timeline

It's happening in EntityDataRequestHandler line 503. I don't know how to flush the response in mediawiki.

I had a dig around yesterday to figure out where something was being added to the body, but didn't see anything.

The output is P9723

Pretty odd..

WMDE-leszek added a comment.EditedFri, Nov 22, 12:20 PM

P9723 is simply the HTML of the pure "chrome" from the skin, without any content, right?

I would not be surprised is what Wikibase does is first generating HTML output of at least non-Wikibase parts of the page, and then figuring out to do with the request on the Wikibase end.

Change 552505 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Stop outputting anything in case of 304 responses in Special:EntityData

https://gerrit.wikimedia.org/r/552505

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptFri, Nov 22, 1:42 PM
Maintenance_bot moved this task from Incoming to In progress on the User-Ladsgroup board.

Change 552519 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.5] Stop outputting anything in case of 304 responses in Special:EntityData

https://gerrit.wikimedia.org/r/552519

Change 552505 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Stop outputting anything in case of 304 responses in Special:EntityData

https://gerrit.wikimedia.org/r/552505

Change 552519 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.5] Stop outputting anything in case of 304 responses in Special:EntityData

https://gerrit.wikimedia.org/r/552519

Mentioned in SAL (#wikimedia-operations) [2019-11-22T15:16:47Z] <ladsgroup@deploy1001> Synchronized php-1.35.0-wmf.5/extensions/Wikibase/repo/: Stop outputting anything in case of 304 responses in Special:EntityData (T238901) (duration: 00m 57s)

last BAD_INCOMING_RESPONSE error on cp1075 was a few seconds before deploying this:

20191122.15h16m44s CONNECT:[0] could not connect [BAD_INCOMING_RESPONSE] to 10.2.2.1 for 'https://appservers-rw.discovery.wmnet/wiki/Q76150152?action=constraintsrdf&nocache=1574435804338

it looks like it is solved, thanks!