Page MenuHomePhabricator

Eliminate usage of mocha-eslint from proton
Closed, ResolvedPublic

Description

This task is about removing the use of mocha-eslint from one of the node services, Proton. See parent ticket for more details, and some pull requests to remove other services for reference.

Getting started steps

Event Timeline

Yeah, the task is still valid. See parent ticket for examples of patches that fix the issue in other services. Those can be a good starting point.

Change 709814 had a related patch set uploaded (by Acaldwell; author: Acaldwell):

[mediawiki/services/chromium-render@master] Removed mocha-eslint because it is no longer maintained.

https://gerrit.wikimedia.org/r/709814

Hello, I wanted to follow up on this issue, and see if what I submitted as the PR was sufficient enough. If there is no more work to do, please let me know.

Hello, I wanted to follow up on this issue, and see if what I submitted as the PR was sufficient enough. If there is no more work to do, please let me know.

Hey, sorry, looks like the team never looked at this. I've reviewed and tweaked it, and am landing it now. Thank you!

Change 709814 merged by jenkins-bot:

[mediawiki/services/chromium-render@master] build: Remove mocha-eslint because it is no longer maintained

https://gerrit.wikimedia.org/r/709814