Page MenuHomePhabricator

Clean up abusefilter.php
Closed, DeclinedPublic

Description

Abusefilter.php currently assigns rights in a manner that duplicates the defaults provided in https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/AbuseFilter/+/refs/heads/master/extension.json

Such duplicate entries should be removed

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

The defaults are:

Extension
"*": {
	"abusefilter-view": true,
	"abusefilter-log": true
},
"sysop": {
	"abusefilter-log-detail": true,
	"abusefilter-view-private": true,
	"abusefilter-log-private": true,
	"abusefilter-modify": true,
	"abusefilter-modify-restricted": true,
	"abusefilter-revert": true
},
"suppress": {
	"abusefilter-hidden-log": true,
	"abusefilter-hide-log": true
}

and

File
$wgGroupPermissions['autoconfirmed']['abusefilter-log-detail'] = true; // T44012
$wgGroupPermissions['sysop']['abusefilter-privatedetails'] = false;
$wgGroupPermissions['sysop']['abusefilter-privatedetails-log'] = false;
$wgGroupPermissions['checkuser']['abusefilter-privatedetails'] = true;
$wgGroupPermissions['checkuser']['abusefilter-privatedetails-log'] = true;
$wgGroupPermissions['sysop']['abusefilter-revert'] = false;

Change 552610 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[operations/mediawiki-config@master] Clean up abusefilter.php

https://gerrit.wikimedia.org/r/552610

DannyS712 removed DannyS712 as the assignee of this task.

Change 552610 abandoned by DannyS712:
[operations/mediawiki-config@master] abusefilter.php: Remove settings that duplicate defaults, and clean up

Reason:

https://gerrit.wikimedia.org/r/552610

Is there a reason behind this being abandoned for the record?

Me cleaning out stale patches, nothing else