Page MenuHomePhabricator

Internal error when trying to revert MCR edits: "Unsaved old revision passed"
Closed, DuplicatePublic

Description

Steps to Reproduce:
Open a Multi-Content Revisions undo form, like https://commons.wikimedia.org/w/index.php?title=File:Powered_by_MediaWiki.svg&action=mcrundo&undo=377299843&undoafter=374177203

Actual Results:

[XdllSApAADoAABlS1oIAAABH] 2019-11-23 16:58:48: Fatal exception of type "InvalidArgumentException"

Expected Results:
The revert form appears.

Details

Request ID
XdllSApAADoAABlS1oIAAABH
Request URL
https://commons.wikimedia.org/w/index.php?title=File:Powered_by_MediaWiki.svg&action=mcrundo&undo=377299843&undoafter=374177203
Stack Trace
#0 /srv/mediawiki/php-1.35.0-wmf.5/includes/Revision/RevisionStore.php(3482): MediaWiki\Revision\RevisionStore->assertRevisionParameter(string, integer, MediaWiki\Revision\MutableRevisionRecord)
#1 /srv/mediawiki/php-1.35.0-wmf.5/includes/diff/DifferenceEngine.php(1552): MediaWiki\Revision\RevisionStore->countRevisionsBetween(integer, MediaWiki\Revision\MutableRevisionRecord, MediaWiki\Revision\RevisionStoreCacheRecord, integer)
#2 /srv/mediawiki/php-1.35.0-wmf.5/includes/diff/DifferenceEngine.php(1052): DifferenceEngine->getMultiNotice()
#3 /srv/mediawiki/php-1.35.0-wmf.5/includes/actions/McrUndoAction.php(242): DifferenceEngine->getDiff(string, string)
#4 /srv/mediawiki/php-1.35.0-wmf.5/includes/actions/McrUndoAction.php(374): McrUndoAction->generateDiffOrPreview()
#5 /srv/mediawiki/php-1.35.0-wmf.5/includes/htmlform/fields/HTMLInfoField.php(25): McrUndoAction->{closure}(array)
#6 /srv/mediawiki/php-1.35.0-wmf.5/includes/htmlform/HTMLForm.php(1699): HTMLInfoField->getDefault()
#7 /srv/mediawiki/php-1.35.0-wmf.5/includes/htmlform/HTMLForm.php(1299): HTMLForm->displaySection(array, string)
#8 /srv/mediawiki/php-1.35.0-wmf.5/includes/htmlform/OOUIHTMLForm.php(254): HTMLForm->getBody()
#9 /srv/mediawiki/php-1.35.0-wmf.5/includes/htmlform/HTMLForm.php(1076): OOUIHTMLForm->getBody()
#10 /srv/mediawiki/php-1.35.0-wmf.5/includes/htmlform/HTMLForm.php(1055): HTMLForm->getHTML(boolean)
#11 /srv/mediawiki/php-1.35.0-wmf.5/includes/htmlform/HTMLForm.php(606): HTMLForm->displayForm(boolean)
#12 /srv/mediawiki/php-1.35.0-wmf.5/includes/actions/FormAction.php(143): HTMLForm->show()
#13 /srv/mediawiki/php-1.35.0-wmf.5/includes/actions/McrUndoAction.php(90): FormAction->show()
#14 /srv/mediawiki/php-1.35.0-wmf.5/includes/MediaWiki.php(514): McrUndoAction->show()
#15 /srv/mediawiki/php-1.35.0-wmf.5/includes/MediaWiki.php(304): MediaWiki->performAction(ImagePage, Title)
#16 /srv/mediawiki/php-1.35.0-wmf.5/includes/MediaWiki.php(967): MediaWiki->performRequest()
#17 /srv/mediawiki/php-1.35.0-wmf.5/includes/MediaWiki.php(530): MediaWiki->main()
#18 /srv/mediawiki/php-1.35.0-wmf.5/index.php(46): MediaWiki->run()
#19 /srv/mediawiki/w/index.php(3): require(string)
#20 {main}

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 23 2019, 5:00 PM
Tacsipacsi triaged this task as Unbreak Now! priority.Nov 23 2019, 5:01 PM

It makes impossible to revert MCR edits.

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptNov 23 2019, 5:01 PM
JJMC89 changed the subtype of this task from "Bug Report" to "Production Error".
JJMC89 set Request URL to https://commons.wikimedia.org/w/index.php?title=File:Powered_by_MediaWiki.svg&action=mcrundo&undo=377299843&undoafter=374177203.
JJMC89 set Request ID to XdllSApAADoAABlS1oIAAABH.
Aklapper renamed this task from [Regression] Internal error when trying to revert MCR edits to Internal error when trying to revert MCR edits: "Unsaved old revision passed".Nov 24 2019, 12:50 AM
Aklapper added a project: Regression.
Aklapper edited Stack Trace. (Show Details)

May fixed by T236320, because it has the same error message and stack trace

Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptDec 2 2019, 8:29 PM