Page MenuHomePhabricator

Regex search return incorrect number of results when highlighter throws exception
Open, MediumPublic

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 23 2019, 11:01 PM
EBernhardson added a subscriber: EBernhardson.EditedNov 25 2019, 4:39 PM

The request basically asks to run a regex against 76M titles and fails with timeouts. While the error messages could be improved, this is such a niche thing that I don't think it's particularly important. This happens to fail the timeout in a different way than other things, but the only improvement i would probably be able to offer is to replace the whole search results page in this use case with a message that effectively says "dont do that"

While it doesn't say timeout, the request spins for some time and eventually the backend gives up and reports a failure. As i said the error messages shown to users could be improved, but the request would still fail.

Hmm, the request with only 222 items is interesting, will look at that

EBernhardson renamed this task from Search return incorrect number of results to Regex search return incorrect number of results when highlighter throws exception.Dec 9 2019, 11:19 PM
EBernhardson triaged this task as Medium priority.
EBernhardson moved this task from needs triage to elastic / cirrus on the Discovery-Search board.