Page MenuHomePhabricator

Usage of ins instead of span creates div blocks in revisions differ
Open, Needs TriagePublic

Description

Hello. In the last couple of weeks there is a weird behavior in revisions differ. It uses <ins/> instead of <span/> to show changed parts of the text, and this <ins/> unexpectedly creates <div/> block instead of <span/> inline. See for example here. The right answer in the first case, for example, should be

ל[[אזור הרפאים]] {{אנ
|Phantom zone}}
ונמלט

(end of lines added just to avoid phabricator direction problem). As you can see, there is not just a redundant white space, but the result is shown in the wrong line, in the middle of irrelevant text. Checked on multiple browsers.
Thank you.

Event Timeline

Hmm, I can't reproduce. I tried in Firefox and in Chrome, logged in and logged out, and I don't see the problem.

Screenshot_2019-11-24 הבדלים בין גרסאות בדף סמולוויל – ויקיפדיה.png (844×2 px, 147 KB)

Hmm, I can't reproduce. I tried in Firefox and in Chrome, logged in and logged out, and I don't see the problem.

Well, @Amire80, this is what I can see.

Screenshot_20191125-000458_Samsung Internet.jpg (1×1 px, 621 KB)

OK, I can reproduce it in the Samsung Internet browser, and only in the desktop view on mobile.

I cannot reproduce it in Chrome or Firefox on Android.

I am on Samsung Browser now, but I saw it a lot on desktop Firefox.

And the problem is that it sometimes disappears in safemode, and sometimes doesn't. My guess it depends on screen width in every single example.

And the problem is that it sometimes disappears in safemode, and sometimes doesn't. My guess it depends on screen width in every single example.

In that case please provide your screen width and browser zoom level. (And for future reference, please always include browser information.)

Also, going to https://he.wikipedia.org/w/index.php?title=סמולוויל&diff=26747890&oldid=26747811 in Firefox 70 I don't see a green background in those four paragraphs. Where does that come from?

In that case please provide your screen width and browser zoom level. (And for future reference, please always include browser information.)

1280 pixels. How can I recognize the browser zoom level?

Also, going to https://he.wikipedia.org/w/index.php?title=סמולוויל&diff=26747890&oldid=26747811 in Firefox 70 I don't see a green background in those four paragraphs. Where does that come from?

A line in my personal common.css

.diff-deletedline, .diff-addedline {background: #EAFAEA;}

1280 pixels. How can I recognize the browser zoom level?

Depends on the browser. Your browser's help pages might be the best place to ask questions about your browser. :)

This particular example is on Samsung Internet, same browser as of Amire80. I did not check this example on Firefox yet.

Well, @Amire80, here is the last FireFox on Desktop Windows:

image.png (431×1 px, 26 KB)

see here.