Unconverted HTML entities in error message
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Ammarpad
	Nov 25 2019, 6:55 AM

Description

While importing, if there's an error connecting to the API, some error messages display quotes as literal HTML entities.

Screen Shot 2019-11-25 at 7.51.35 AM.png (317×1 px, 64 KB)

The message should display the quotes properly

Details

Subject	Repo	Branch	Lines +/-
FileImporter: Unconverted HTML entities in error message	mediawiki/extensions/FileImporter	master	+2 -2
GCI task: Convert HTML entity to plain character in error message	mediawiki/extensions/FileImporter	master	+1 -1
GCI task: Convert HTML entity to plain character in error message	mediawiki/extensions/FileImporter	master	+3 -3

Customize query in gerrit

Related Objects

Mentioned In: rEFLIe6da3ecc63b2: GCI task: Convert HTML entity to plain character in error message

Event Timeline

Ammarpad created this task.Nov 25 2019, 6:55 AM

Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptNov 25 2019, 6:55 AM

Ammarpad added a project: Google-Code-in-2019.Nov 25 2019, 6:56 AM

JJMC89 changed the subtype of this task from "Task" to "Bug Report".Nov 25 2019, 7:00 AM

Imported to GCI site: https://codein.withgoogle.com/dashboard/tasks/6511843779018752/

Change 554824 had a related patch set uploaded (by Kretu; owner: Kretu):
[mediawiki/extensions/FileImporter@master] FileImporter: Unconverted HTML entities in error message

https://gerrit.wikimedia.org/r/554824

gerritbot added a project: Patch-For-Review.Dec 5 2019, 11:35 AM

Ammarpad assigned this task to Kretu.Dec 5 2019, 4:37 PM

Ammarpad triaged this task as Medium priority.

@Ammarpad https://codein.withgoogle.com/tasks/6511843779018752/?sp-organization=6260468339965952 ???

Anyway I can help? That task is free, I am aware the student abandoned it.

Change 557598 had a related patch set uploaded (by Ammarpad; owner: Alexandersheetov1):
[mediawiki/extensions/FileImporter@master] GCI task: Convert HTML entity to plain character in error message

https://gerrit.wikimedia.org/r/557598

Change 557831 had a related patch set uploaded (by Alexandersheetov1; owner: Alexandersheetov1):
[mediawiki/extensions/FileImporter@master] Update gci

https://gerrit.wikimedia.org/r/557831

Ammarpad assigned this task to Alexandersheetov1.Dec 16 2019, 10:10 AM

Change 557831 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] GCI task: Convert HTML entity to plain character in error message

https://gerrit.wikimedia.org/r/557831

Ammarpad mentioned this in rEFLIe6da3ecc63b2: GCI task: Convert HTML entity to plain character in error message.Dec 17 2019, 12:31 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.14; 2020-01-07).Dec 17 2019, 1:00 PM

Ammarpad closed this task as Resolved.Dec 17 2019, 2:06 PM

Ammarpad removed a project: Patch-For-Review.Dec 24 2019, 3:50 PM

Change 557598 abandoned by Thiemo Kreuz (WMDE):
GCI task: Convert HTML entity to plain character in error message

Reason:
Submitted twice as Icc1bee9, which is merged by now.