Page MenuHomePhabricator

Internal error while browsing diffs on Special:Undelete: "Revision 207278230 doesn't belong to page 0"
Closed, DuplicatePublicPRODUCTION ERROR

Description

Please choose a deleted file and press a "diff" link in "Page history" section. E.g. for File:Colegio-WARD entrada-y-frente -barrio-de-morón.jpg I got [XduYgApAIC4AAF3DE@cAAADA] 2019-11-25 09:01:52: Fatal exception of type "InvalidArgumentException". Tested on a few different files. Perhaps somehow it is related to T236320?

Details

Request ID
XduYgApAIC4AAF3DE@cAAADA
Stack Trace

#0 /srv/mediawiki/php-1.35.0-wmf.5/includes/Revision/RevisionStore.php(3482): MediaWiki\Revision\RevisionStore->assertRevisionParameter(string, integer, MediaWiki\Revision\RevisionArchiveRecord)
#1 /srv/mediawiki/php-1.35.0-wmf.5/includes/diff/DifferenceEngine.php(1552): MediaWiki\Revision\RevisionStore->countRevisionsBetween(integer, MediaWiki\Revision\RevisionArchiveRecord, MediaWiki\Revision\RevisionArchiveRecord, integer)
#2 /srv/mediawiki/php-1.35.0-wmf.5/includes/diff/DifferenceEngine.php(1052): DifferenceEngine->getMultiNotice()
#3 /srv/mediawiki/php-1.35.0-wmf.5/includes/specials/SpecialUndelete.php(583): DifferenceEngine->getDiff(string, string)
#4 /srv/mediawiki/php-1.35.0-wmf.5/includes/specials/SpecialUndelete.php(429): SpecialUndelete->showDiff(Revision, Revision)
#5 /srv/mediawiki/php-1.35.0-wmf.5/includes/specials/SpecialUndelete.php(204): SpecialUndelete->showRevision(string)
#6 /srv/mediawiki/php-1.35.0-wmf.5/includes/specialpage/SpecialPage.php(575): SpecialUndelete->execute(NULL)
#7 /srv/mediawiki/php-1.35.0-wmf.5/includes/specialpage/SpecialPageFactory.php(607): SpecialPage->run(NULL)
#8 /srv/mediawiki/php-1.35.0-wmf.5/includes/MediaWiki.php(298): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#9 /srv/mediawiki/php-1.35.0-wmf.5/includes/MediaWiki.php(967): MediaWiki->performRequest()
#10 /srv/mediawiki/php-1.35.0-wmf.5/includes/MediaWiki.php(530): MediaWiki->main()
#11 /srv/mediawiki/php-1.35.0-wmf.5/index.php(46): MediaWiki->run()
#12 /srv/mediawiki/w/index.php(3): require(string)
#13 {main}

Event Timeline

Aklapper renamed this task from Internal error while browsing diffs on Special:Undelete to Internal error while browsing diffs on Special:Undelete: "Revision 207278230 doesn't belong to page 0".Nov 25 2019, 2:21 PM
Aklapper changed the subtype of this task from "Task" to "Production Error".
Aklapper set Request ID to XduYgApAIC4AAF3DE@cAAADA.
Aklapper edited Stack Trace. (Show Details)

XeMHHApAAEMAACG0Aw4AAACC is the same error on huwiki, so not specific to Commons or structured media info.

Introduced by rMW6eb67c752e55: Move countRevisionsBetween from Title to RevisionStore. Probably also affects difflinks comparing revisions from two different pages, not just deleted pages.