Page MenuHomePhabricator

Record the dates of whenever a user agrees/disagrees to the Terms of Use
Closed, ResolvedPublic

Description

Users can agree or disagree to the ToU whenever they want. Ideally we'd want to know when they did so for legal reasons.

Event Timeline

AVasanth_WMF renamed this task from Preserve the state of Terms of Use for all users to Record the dates of whenever a user agrees/disagrees to the Terms of Use.Nov 25 2019, 12:33 PM

Hello @Samwalton9,

I have been working on this ticket and would like to know more about this ticket.

Please feel free to modify, comment, and deny this pull request. I will appreciate your feedback.
https://github.com/WikipediaLibrary/TWLight/pull/448

  1. I updated TermsView to overwrite 'terms_of_use_date' when a user disagrees with the term. Basically, 'terms_of_use_date' becomes 'last updated date of terms of use'. Please let me know this approach is appropriate.
  1. I added TermsForm to the Profile page. It will be only shown for the user who has already accepted terms of use. It also overwrites terms_of_use_date.

Profile_page.png (1×2 px, 145 KB)

Please let me know if you have any questions.

Thank you,
Kangyoon Bae

Thanks for working on this!

Your solution looks great, we're happy with only knowing the last time they changed their preferences. Having a preference right on the user page also makes sense, but could you link some text there to the Terms of Use page?

Hello @Samwalton9,

Thank you for clarifying the ticket. I added the link for the Terms of Use page on the user preferences.

user_profile_terms_of_use.png (698×2 px, 77 KB)

terms_of_use_link.png (236×1 px, 62 KB)

Please let me know if you have any questions.

@Samwalton9: Could https://github.com/WikipediaLibrary/TWLight/pull/448 get another review? (Also, should this really be under "Done" when not merged?) TIA!

We're using the 'Done' column such that tasks here reflect completed PRs which are being reviewed/aren't merged yet.

This will get a review and merge once we've completed some other work - review and merge of other PRs is paused for now.