Replace `heading-holder` by `heading-container`
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Volker_E
	Nov 25 2019, 6:01 PM

Description

We don't use holder anywhere besides .heading-holder. Most other containers, wrappers, boxes or holders are named
container.
Let's unify the naming here by

introducing heading-container class
replacing all heading-holder by heading-container classes

Event Timeline

Volker_E created this task.Nov 25 2019, 6:01 PM

Restricted Application added a project: UI-Standardization. · View Herald TranscriptNov 25 2019, 6:01 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Why not BEM?

In T239142#5690726, @Jdlrobson wrote:

Why not BEM?

This would be the block (at best) –– it's neither element nor modifier currently. But that's not my main concern.

We would separate core and other skins more without a clear naming architecture. If everything else is banner-container, cnotice-logo-container, cnotice-message-container`, read-more-container it's not logically otherwise.

Izno moved this task from Backlog to Change CSS Hook on the CSS board.Jan 2 2020, 4:18 PM

Sanyam.wikime moved this task from Change CSS Hook to Change CSS on the CSS board.Jan 11 2020, 5:00 PM

Sanyam.wikime moved this task from Change CSS to Change CSS Hook on the CSS board.

Jdlrobson moved this task from Backlog to Blocked on Discussion on the MinervaNeue board.Jan 17 2020, 10:50 PM

Jdlrobson moved this task from Blocked on Discussion to Blocked on the MinervaNeue board.Jul 21 2021, 7:27 PM

Replace `heading-holder` by `heading-container`Open, Needs TriagePublicActions

Description

Event Timeline

Replace `heading-holder` by `heading-container`
Open, Needs TriagePublic
Actions