Page MenuHomePhabricator

Mitigate race conditions from horizon writing to instance-puppet git
Closed, ResolvedPublic

Description

Right now Horizon doesn't handle simultaneous edits to instance puppet config very well... it's probably possible to get our git repo wedged in such a way that it's unable to push.

Something like https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/552583/ would reduce the risk of this.

Details

Related Gerrit Patches:
operations/puppet : productionhorizon: remove PUPPET_GIT_REPO_PATH config
openstack/horizon/deploy : ocataUpdate wmf-puppet-dashboard submodule
openstack/horizon/wmf-puppet-dashboard : ocatainstance puppet repo: create a new temporary checkout for each merge
openstack/horizon/deploy : trainupdate wmf-puppet-dashboard submodule
openstack/horizon/wmf-puppet-dashboard : traininstance puppet repo: create a new temporary checkout for each merge
openstack/horizon/wmf-puppet-dashboard : traininstance puppet repo: create a new temporary checkout for each merge

Event Timeline

Andrew created this task.Nov 25 2019, 6:20 PM

Change 555766 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[openstack/horizon/wmf-puppet-dashboard@train] instance puppet repo: create a new temporary checkout for each merge

https://gerrit.wikimedia.org/r/555766

Change 555766 abandoned by Andrew Bogott:
instance puppet repo: create a new temporary checkout for each merge

https://gerrit.wikimedia.org/r/555766

Change 555767 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[openstack/horizon/wmf-puppet-dashboard@ocata] instance puppet repo: create a new temporary checkout for each merge

https://gerrit.wikimedia.org/r/555767

Change 555768 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[openstack/horizon/wmf-puppet-dashboard@train] instance puppet repo: create a new temporary checkout for each merge

https://gerrit.wikimedia.org/r/555768

Change 555768 merged by Andrew Bogott:
[openstack/horizon/wmf-puppet-dashboard@train] instance puppet repo: create a new temporary checkout for each merge

https://gerrit.wikimedia.org/r/555768

Change 555769 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[openstack/horizon/deploy@train] update wmf-puppet-dashboard submodule

https://gerrit.wikimedia.org/r/555769

Change 555769 merged by Andrew Bogott:
[openstack/horizon/deploy@train] update wmf-puppet-dashboard submodule

https://gerrit.wikimedia.org/r/555769

Change 555767 merged by Andrew Bogott:
[openstack/horizon/wmf-puppet-dashboard@ocata] instance puppet repo: create a new temporary checkout for each merge

https://gerrit.wikimedia.org/r/555767

Change 555771 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[openstack/horizon/deploy@ocata] Update wmf-puppet-dashboard submodule

https://gerrit.wikimedia.org/r/555771

Change 555771 merged by Andrew Bogott:
[openstack/horizon/deploy@ocata] Update wmf-puppet-dashboard submodule

https://gerrit.wikimedia.org/r/555771

Change 555773 had a related patch set uploaded (by Andrew Bogott; owner: Andrew Bogott):
[operations/puppet@production] horizon: remove PUPPET_GIT_REPO_PATH config

https://gerrit.wikimedia.org/r/555773

Change 555773 merged by Andrew Bogott:
[operations/puppet@production] horizon: remove PUPPET_GIT_REPO_PATH config

https://gerrit.wikimedia.org/r/555773

Andrew closed this task as Resolved.Dec 9 2019, 4:26 AM