Page MenuHomePhabricator

Deferred update EchoHooks::onPageContentSaveComplete failed: Argument passed to generateMentionEvents() must be array
Open, Needs TriagePublic

Description

Error

MediaWiki version: 1.35.0-wmf.5

message
Deferred update MWCallableUpdate_EchoHooks::onPageContentSaveComplete failed: Argument 2 passed to EchoDiscussionParser::generateMentionEvents() must be of the type array, boolean given, called in /srv/mediawiki/php-1.35.0-wmf.5/extensions/Echo/includes/DiscussionParser.php on line 61
exception.trace
#0 /srv/mediawiki/php-1.35.0-wmf.5/extensions/Echo/includes/DiscussionParser.php(61): EchoDiscussionParser::generateMentionEvents('T\xE1\xBA\xA1o b\xC3\xA0i m\xE1\xBB\x9B...', false, '\nCh\xC3\xA0o m\xE1\xBB\xABng b...', Object(MediaWiki\Revision\RevisionStoreRecord), Object(User))
#1 /srv/mediawiki/php-1.35.0-wmf.5/extensions/Echo/includes/EchoHooks.php(547): EchoDiscussionParser::generateEventsForRevision(Object(MediaWiki\Revision\RevisionStoreRecord), false)
#2 /srv/mediawiki/php-1.35.0-wmf.5/includes/deferred/MWCallableUpdate.php(38): EchoHooks::{closure}()
#3 /srv/mediawiki/php-1.35.0-wmf.5/includes/deferred/DeferredUpdates.php(385): MWCallableUpdate->doUpdate()
#4 /srv/mediawiki/php-1.35.0-wmf.5/includes/deferred/DeferredUpdates.php(283): DeferredUpdates::attemptUpdate(Object(MWCallableUpdate), Object(Wikimedia\Rdbms\LBFactoryMulti))
#5 /srv/mediawiki/php-1.35.0-wmf.5/includes/deferred/DeferredUpdates.php(228): DeferredUpdates::run(Object(MWCallableUpdate), Object(Wikimedia\Rdbms\LBFactoryMulti), Object(Monolog\Logger), Object(BufferingStatsdDataFactory), 'post')
#6 /srv/mediawiki/php-1.35.0-wmf.5/includes/deferred/DeferredUpdates.php(150): DeferredUpdates::handleUpdateQueue(Array, 'run', 2)
#7 /srv/mediawiki/php-1.35.0-wmf.5/includes/MediaWiki.php(1053): DeferredUpdates::doUpdates('run')
#8 /srv/mediawiki/php-1.35.0-wmf.5/includes/MediaWiki.php(833): MediaWiki->restInPeace()
#9 /srv/mediawiki/php-1.35.0-wmf.5/includes/MediaWiki.php(842): MediaWiki->{closure}()
#10 /srv/mediawiki/php-1.35.0-wmf.5/api.php(118): MediaWiki->doPostOutputShutdown()
#11 /srv/mediawiki/w/api.php(3): require('/srv/mediawiki/...')
#12 {main}

Impact

Notes

Details

Request ID
Xd2OdwpAIDcAAFT4TiIAAAAP
Request URL
https://vi.wikipedia.org/w/api.php?format=xml&action=edit&…
Related Gerrit Patches:
mediawiki/extensions/Echo : masterDiscussionParser: Fix type hint fatal from getUserLinks()
mediawiki/extensions/Echo : wmf/1.35.0-wmf.8DiscussionParser: Fix type hint fatal from getUserLinks()

Event Timeline

Krinkle created this task.Tue, Nov 26, 8:57 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptTue, Nov 26, 8:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 553232 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/Echo@master] DiscussionParser: Fix type hint fatal from getUserLinks()

https://gerrit.wikimedia.org/r/553232

It turns out the other tasks were not related, this was just a bad type hint.

Catrope claimed this task.Wed, Nov 27, 1:59 AM
Catrope edited projects, added Growth-Team (Current Sprint); removed Growth-Team.
Catrope moved this task from Incoming to Code Review on the Growth-Team (Current Sprint) board.

Change 553232 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] DiscussionParser: Fix type hint fatal from getUserLinks()

https://gerrit.wikimedia.org/r/553232

Change 553354 had a related patch set uploaded (by Krinkle; owner: Catrope):
[mediawiki/extensions/Echo@wmf/1.35.0-wmf.8] DiscussionParser: Fix type hint fatal from getUserLinks()

https://gerrit.wikimedia.org/r/553354

Change 553354 merged by jenkins-bot:
[mediawiki/extensions/Echo@wmf/1.35.0-wmf.8] DiscussionParser: Fix type hint fatal from getUserLinks()

https://gerrit.wikimedia.org/r/553354

Mentioned in SAL (#wikimedia-operations) [2019-12-03T00:25:43Z] <jforrester@deploy1001> Synchronized php-1.35.0-wmf.8/extensions/Echo/includes/DiscussionParser.php: T239275 Fix type hint fatal from getUserLinks() (duration: 01m 16s)

Notes for testing: check mdiawiki-new-errors dashboars after wmf.8 will be deployed to group 2. Presently, there are numerous errros on DeferredUpdates (especially for viwiki).

brennen added a subscriber: brennen.Wed, Dec 4, 9:14 PM