Page MenuHomePhabricator

Page Curation: Fix Requeue Bug for Redirects
Open, Needs TriagePublic

Description

As a PM, I want the bug associated with T207485 fixed, so that articles put back into the queue aren't removed & NPP does not experience additional issues.

Background: @MaxSem was working on T207485 as one of his last tickets. He was able to complete most of the work, but there was one remaining bug: If a page is manually added to the New Pages Feed via the Curation Toolbar, and if the page is a redirect (i.e., not an article), it will be removed from the queue when the next cron job is performed. The cron job occurs about once a day. This means that, in extremely rare circumstances, the page will be removed immediately (if it's added when the cron job is being performed). In much more common cases, it will be removed after a certain period of time (about 24 hours maximum) after being added to the queue.

Generally speaking, this is an edge case because: a) a page would need be manually added to the New Pages Feed (rather than the automatic process that happens when the page is first created), b) the page would need to be a redirect, and c) the page would need to stay in the queue rather than being reviewed. In most cases, pages are reviewed once when they are automatically added. If they are added to New Pages feed manually, they tend to be articles. If they are redirects, they tend to be reviewed rather quickly.

Acceptance Criteria:

  • Old articles that have been put back into the queue should not be removed, if they are redirects (or are like articles mentioned in T207485#5337188).

Event Timeline

ifried renamed this task from Page Curation: Fix Requeue Bug to Page Curation: Fix Requeue Bug [discuss during Monday estimation].Nov 28 2019, 12:17 AM
ifried renamed this task from Page Curation: Fix Requeue Bug [discuss during Monday estimation] to Page Curation: Fix Requeue Bug.Dec 4 2019, 9:51 PM
ifried renamed this task from Page Curation: Fix Requeue Bug to Page Curation: Fix Requeue Bug for Redirects & User Pages.
MPGuy2824 renamed this task from Page Curation: Fix Requeue Bug for Redirects & User Pages to Page Curation: Fix Requeue Bug for Redirects.Oct 16 2023, 8:49 AM
MPGuy2824 updated the task description. (Show Details)
MPGuy2824 added a subscriber: MaxSem.