Page MenuHomePhabricator

Fix tracking events for mobile banners
Closed, ResolvedPublic

Description

While working on the export for T235507, I noticed that there is no event tracking data at all stored for any of the mobile banners (English and German). I had a look at the code with Gabriel and we could not find any obvious reasons for why this would be broken, so we will need to investigate this further and fix this. As of now, the tracking events for the mobile banners does not seem to work for some reason.

Event Timeline

Investigation result so far:

  • All except mobile track the click on "Application of funds" with a ratio of 100%. I've added that tracking to Test 03 to see if at least that one shows up.
  • All except mobile track the close button via "BannerSizeIssues", the mobile banners use "BannerEvent". All Banners use a ratio of 1%.
  • Turning on logging and the ratio to 100% on a "tracking test banner" shows that the code that sends information to event logging is called.

With these facts, my current hypothesis is that somehow the banner-closed and mobile-mini-banner-expanded are somehow lost when they are processed on the WMF analytics infrastructure. I'll ask people more knowledgeable with the infrastructure on how to investigate the hypothesis.

Found the error: The latest deployed schema version is 18437830, which lacks the slider parameters (introduced in rev. 18193948). Events with slider params (close and expansion) get rejected. I'll change the schema to be more lenient and deploy a new version.

Can you change the banners to use the deployed schema version until the new schema is ready?

Change 554296 had a related patch set uploaded (by Gabriel Birke; owner: Gabriel Birke):
[mediawiki/extensions/WikimediaEvents@master] Change Schema Revision of WMDEBannerEvents

https://gerrit.wikimedia.org/r/554296

Change 554296 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] Change Schema Revision of WMDEBannerEvents

https://gerrit.wikimedia.org/r/554296

Change 554492 had a related patch set uploaded (by Urbanecm; owner: Gabriel Birke):
[mediawiki/extensions/WikimediaEvents@wmf/1.35.0-wmf.5] Change Schema Revision of WMDEBannerEvents

https://gerrit.wikimedia.org/r/554492

Change 554493 had a related patch set uploaded (by Urbanecm; owner: Gabriel Birke):
[mediawiki/extensions/WikimediaEvents@wmf/1.35.0-wmf.8] Change Schema Revision of WMDEBannerEvents

https://gerrit.wikimedia.org/r/554493

Change 554492 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@wmf/1.35.0-wmf.5] Change Schema Revision of WMDEBannerEvents

https://gerrit.wikimedia.org/r/554492

Change 554493 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@wmf/1.35.0-wmf.8] Change Schema Revision of WMDEBannerEvents

https://gerrit.wikimedia.org/r/554493

Mentioned in SAL (#wikimedia-operations) [2019-12-04T12:26:45Z] <urbanecm@deploy1001> Synchronized php-1.35.0-wmf.8/extensions/WikimediaMessages/: SWAT: b3ef5cd: Change Schema Revision of WMDEBannerEvents (T239430) (duration: 01m 04s)

Mentioned in SAL (#wikimedia-operations) [2019-12-04T12:28:48Z] <urbanecm@deploy1001> Synchronized php-1.35.0-wmf.5/extensions/WikimediaMessages/: SWAT: bbf2a33: Change Schema Revision of WMDEBannerEvents (T239430) (duration: 01m 02s)

Tim_WMDE moved this task from Doing to Done on the WMDE-FUN-Funban-2019 board.

SWAT deployment is done, mobile tracking should start showing data from 12:30 UTC time if all went well.

kai.nissen claimed this task.