Page MenuHomePhabricator
Create Task
Maniphest T239447

Users without their e-mail confirmed get an error when trying to upload avatar
Closed, ResolvedPublic
Actions

Description

My Wiki has e-mail authentication ($wgEmailConfirmToEdit = true;) set to help prevent vandalism. Some users realized that they are unable to upload avatars before they confirm their e-mail because this error message appears: https://jojowiki.com/Special:WikiForum/Avatar_Errors

This makes sense since I don't think they're allowed to upload files before they confirm their e-mail. Is there a way to display a cleaner message like "Please confirm your e-mail address before uploading avatar" instead of the backtrace? Thanks.

Details

SubjectRepoBranchLines +/-
Set mFileProps in UploadAvatar#verifyUpload to keep AbuseFilter happymediawiki/extensions/SocialProfilemaster+11 -0
Don't die horribly when email confirmation is required to edit pages and a user w/ an unconfirmed email tries to upload an avatar via Special:UploadAvatarmediawiki/extensions/SocialProfilemaster+32 -0
Customize query in gerrit

Related Objects

Event Timeline

Vishkujo created this task.Nov 28 2019, 9:14 PM
Restricted Application added a project: Social-Tools. · View Herald TranscriptNov 28 2019, 9:14 PM
gerritbot added a comment.Nov 29 2019, 10:07 AM

Change 553699 had a related patch set uploaded (by Jack Phoenix; owner: Jack Phoenix):
[mediawiki/extensions/SocialProfile@master] Don't die horribly when email confirmation is required to edit pages and a user w/ an unconfirmed email tries to upload an avatar via Special:UploadAvatar

https://gerrit.wikimedia.org/r/553699

gerritbot added a project: Patch-For-Review.Nov 29 2019, 10:07 AM
gerritbot added a comment.Nov 29 2019, 10:18 AM

Change 553699 merged by jenkins-bot:
[mediawiki/extensions/SocialProfile@master] Don't die horribly when email confirmation is required to edit pages and a user w/ an unconfirmed email tries to upload an avatar via Special:UploadAvatar

https://gerrit.wikimedia.org/r/553699

ashley mentioned this in rESPRacef7132f402: Don't die horribly when email confirmation is required to edit pages and a user….Nov 29 2019, 10:20 AM
ashley closed this task as Resolved.Nov 29 2019, 10:27 AM
ashley claimed this task.
ashley removed a project: Patch-For-Review.
ashley subscribed.

Thanks for the bug report! This should now be fixed by the above commit (tested on MW 1.33.0, without AbuseFilter installed though).

Note that since we're essentially using the core MW methods, much like how the regular Special:Upload page uses 'em, the i18n message displayed is confirmedittext, which somewhat misleadingly (for our use case) reads by default "You must confirm your email address before editing pages"; this makes sense for regular file uploads as regular files have an associated on-wiki File: page, but avatar images don't. Furthermore just like with Special:Upload, the error message is displayed *after* the user hits the "upload" button, not before. Regardless, the behavior of SocialProfile's Special:UploadAvatar should now be consistent with core Special:Upload page, for better or for worse. At least it's not fataling anymore should a user without a confirmed email attempt to upload an avatar when the wiki has $wgEmailConfirmToEdit = true; set.

Vishkujo added a comment.Nov 29 2019, 4:54 PM

Thanks for the quick patch. However, I made a test account and it seems to be resolved when AbuseFilter is disabled, but it still shows the same error when it's on.

gerritbot added a comment.Nov 29 2019, 10:44 PM

Change 553781 had a related patch set uploaded (by Jack Phoenix; owner: Jack Phoenix):
[mediawiki/extensions/SocialProfile@master] Set mFileProps in UploadAvatar#verifyUpload to keep AbuseFilter happy

https://gerrit.wikimedia.org/r/553781

gerritbot added a project: Patch-For-Review.Nov 29 2019, 10:44 PM
gerritbot added a comment.Nov 29 2019, 10:47 PM

Change 553781 merged by jenkins-bot:
[mediawiki/extensions/SocialProfile@master] Set mFileProps in UploadAvatar#verifyUpload to keep AbuseFilter happy

https://gerrit.wikimedia.org/r/553781

ashley mentioned this in rESPRcb84f50fddc4: Set mFileProps in UploadAvatar#verifyUpload to keep AbuseFilter happy.Nov 29 2019, 10:48 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 29 2019, 11:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL