Page MenuHomePhabricator

https://doc.wikimedia.org/Wikibase/master/php/deprecated.html lists wrong classes for deprecated methods
Closed, ResolvedPublic

Description

https://doc.wikimedia.org/Wikibase/master/php/deprecated.html

The class shown is "Wikibase", the actual class / file this happens in is Wikibase/lib/includes/Formatters/DispatchingValueFormatter.php

The full path should be \Wikibase\Lib\Formatters\DispatchingValueFormatter

Event Timeline

Addshore created this task.Nov 29 2019, 4:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 29 2019, 4:55 PM

I'm guessing this issue has something to do with this output when generating docs..

12:20:19 deprecated:2: warning: Illegal command Lib as part of a \ref
12:20:19 deprecated:2: warning: Illegal command Formatters as part of a \ref
12:20:19 deprecated:2: warning: Illegal command DispatchingValueFormatter as part of a \ref
Addshore updated the task description. (Show Details)Nov 29 2019, 5:01 PM

Also reported in https://github.com/doxygen/doxygen/issues/6888

I believe a fix was merged in https://github.com/doxygen/doxygen/pull/6549

According to https://github.com/doxygen/doxygen/pull/6549/commits/97f2d220240a1f6692627171398a06a3fa238639

the commit is in Release_1_8_16 Release_1_8_15

And we run:

12:20:14 + doxygen --version
12:20:14 1.8.13
hashar updated the task description. (Show Details)Dec 13 2019, 6:21 PM
hashar closed this task as Resolved.Dec 13 2019, 6:23 PM
hashar claimed this task.
hashar added a subscriber: hashar.

CI now runs Doxygen 1.8.16. The master branch has been regenerated with it already https://doc.wikimedia.org/Wikibase/master/php/deprecated.html

The namespaces show up properly now:

All documentations will eventually be regenerated as part of unbreaking the server side PHP search page. T218233

Thank you @Addshore