Page MenuHomePhabricator

maintenance script addSite.php with options fails always
Closed, ResolvedPublic

Description

# php maintenance/addSite.php --filepath 'http://foo/$1' --pagepath 'http://foo/$1' foo bar
[ba14e729454b189ccc6a61da] [no req]   MWException from line 590 of /srv/femiwiki.com/includes/site/Site.php: $fullUrl needs to be a string
Backtrace:
#0 /srv/femiwiki.com/includes/site/MediaWikiSite.php(153): Site->setPath(string, integer)
#1 /srv/femiwiki.com/maintenance/addSite.php(75): MediaWikiSite->setPagePath(integer)
#2 /srv/femiwiki.com/maintenance/doMaintenance.php(96): AddSite->execute()
#3 /srv/femiwiki.com/maintenance/addSite.php(92): require_once(string)
#4 {main}

$this->getOption( 'language' ) is called from L49-L53, but the declaration of the options(L24-L30) does not seem to be ready to accept parameters.

Event Timeline

Lens0021 created this task.Dec 2 2019, 1:29 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 2 2019, 1:29 AM

Change 553874 had a related patch set uploaded (by Lens0021; owner: Lens0021):
[mediawiki/core@master] Fix the bug that options ignore parameters

https://gerrit.wikimedia.org/r/553874

Lens0021 updated the task description. (Show Details)Dec 2 2019, 1:43 AM

Change 554187 had a related patch set uploaded (by Reedy; owner: Lens0021):
[mediawiki/core@REL1_34] Mark options as requiring parameters in addSite.php

https://gerrit.wikimedia.org/r/554187

Change 554188 had a related patch set uploaded (by Reedy; owner: Lens0021):
[mediawiki/core@REL1_33] Mark options as requiring parameters in addSite.php

https://gerrit.wikimedia.org/r/554188

Change 554189 had a related patch set uploaded (by Reedy; owner: Lens0021):
[mediawiki/core@REL1_31] Mark options as requiring parameters in addSite.php

https://gerrit.wikimedia.org/r/554189

Change 554192 had a related patch set uploaded (by Reedy; owner: Lens0021):
[mediawiki/core@REL1_32] Mark options as requiring parameters in addSite.php

https://gerrit.wikimedia.org/r/554192

Change 553874 merged by jenkins-bot:
[mediawiki/core@master] Mark options as requiring parameters in addSite.php

https://gerrit.wikimedia.org/r/553874

Change 554189 merged by jenkins-bot:
[mediawiki/core@REL1_31] Mark options as requiring parameters in addSite.php

https://gerrit.wikimedia.org/r/554189

Reedy closed this task as Resolved.Dec 2 2019, 11:46 PM

Change 554192 merged by jenkins-bot:
[mediawiki/core@REL1_32] Mark options as requiring parameters in addSite.php

https://gerrit.wikimedia.org/r/554192

Change 554188 merged by jenkins-bot:
[mediawiki/core@REL1_33] Mark options as requiring parameters in addSite.php

https://gerrit.wikimedia.org/r/554188

Change 554187 merged by jenkins-bot:
[mediawiki/core@REL1_34] Mark options as requiring parameters in addSite.php

https://gerrit.wikimedia.org/r/554187