Integrate Parsoid/PHP with core as a composer library
Closed, ResolvedPublicGoal
Actions

Description

Parsoid/PHP is currently used as a faux extension. We adopted this strategy so as to speed up Parsoid/PHP deployment while waiting on PHP 7.x adoption, and addressing technical debt. Now that Parsoid/PHP is in production, and the production clusters use PHP 7.x, we can address the technical debt pieces in Parsoid and stop using Parsoid/PHP as an extension.

Subtasks will address specific aspects of this work.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+3 -0	Add Parsoid as a library dependency
	mediawiki/vendor	master	+17 M -10	Add wikimedia/parsoid at 0.12.0-a2

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T33279 Installer: extensions improvements: descriptions, alternatives, multiselection, configuration (tracking)
Open		None	T178349 Expand the set of bundled extensions and skins to achieve a default MediaWiki experience that's comparable to Wikimedia sites
Resolved		Jdforrester-WMF	T232854 Expand the set of bundled extensions and skins in MediaWiki 1.35
Resolved		Jdforrester-WMF	T243258 Bundle VisualEditor extension with MediaWiki
Open		None	T247804 Move Sanitizer from core into Parsoid
Resolved	Goal	cscott	T239660 Integrate Parsoid/PHP with core as a composer library
Resolved		cscott	T213494 Installing composer modules for deployment
Resolved		cscott	T240054 Move top level namespace from Parsoid to Wikimedia\Parsoid
Resolved		cscott	T240055 Craft a deployment strategy to transition Parsoid/PHP from a faux extension to a composer library without breaking incoming requests
Resolved		Dzahn	T245877 Give all members of the Parsing team production `deployment` access ( add arlolra to deployers)
Declined		Jdforrester-WMF	T245886 Create /srv/mediawiki/parsoid-vendor on production MW appservers, a check out of vendor.git's parsoid branch
Resolved		Jdforrester-WMF	T246854 Replace deployment-mediawiki-parsoid10 with a "purer" deployment-parsoid11 box
Resolved		Jdforrester-WMF	T247147 Puppet fails on Beta Cluster because "did not find a value for the name 'profile::envoy::ensure'"
Resolved		Krenair	T246937 deployment-puppetmaster04 disc use exploding
Resolved		Krenair	T247151 Puppet fails on Beta Cluster because Safe_service_restart is expecting lvs_services set though `has_lvs: false`
Resolved		Dzahn	T247480 Sync parsoid11 config from Horizon back to puppet git
Resolved		Krenair	T247545 Fix scap on deployment-parsoid11
Resolved		cscott	T247589 Parsoid-PHP should be publicly accessible in beta

Event Timeline

Jdforrester-WMF created this task.Dec 2 2019, 8:47 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 2 2019, 8:47 PM

Jdforrester-WMF added a subtask: T229015: Tracking: Direct live production traffic at Parsoid/PHP.Dec 2 2019, 8:48 PM

I am going to unlink this with the subtask because in its current form, I am likely going to decline. I'll post my reasoning shortly and we can discuss and retarget it appropriately.

ssastry removed a subtask: T229015: Tracking: Direct live production traffic at Parsoid/PHP.Dec 6 2019, 6:14 PM

In T239660#5718876, @ssastry wrote:

I am going to unlink this with the subtask because in its current form, I am likely going to decline. I'll post my reasoning shortly and we can discuss and retarget it appropriately.

Or you could re-phase the task into the work you said you were going to do…

ssastry renamed this task from Merge Parsoid PHP code into MediaWiki core to Tracking: Integrate Parsoid/PHP with core as a composer library.Dec 6 2019, 6:58 PM

ssastry triaged this task as Medium priority.

ssastry updated the task description. (Show Details)

ssastry renamed this task from Tracking: Integrate Parsoid/PHP with core as a composer library to Integrate Parsoid/PHP with core as a composer library.Dec 6 2019, 7:02 PM

ssastry updated the task description. (Show Details)

ssastry changed the subtype of this task from "Task" to "Goal".

ssastry added a subtask: T235307: Stop using the Env class outside of the Parsoid library (particularly in the extension REST handlers).Dec 6 2019, 7:05 PM

ssastry added a subtask: T231568: Push more functionality out of SiteConfig subclasses into the root SiteConfig class.

ssastry added a subtask: T213494: Installing composer modules for deployment.

ssastry added a subtask: T229083: Clean up services in Parsoid extension.Dec 6 2019, 7:08 PM

ssastry mentioned this in T239743: Provide cached access to Parsoid PHP within core.Dec 6 2019, 7:11 PM

ssastry removed a project: MediaWiki-Parser.Dec 6 2019, 9:53 PM

ssastry moved this task from Backlog to Porting Tech Debt Redressal on the Parsoid-PHP board.Dec 8 2019, 3:19 AM

ssastry mentioned this in T151308: Make VisualEditor compatible with "extends" parameter.Jan 10 2020, 1:25 PM

Tgr mentioned this in T237819: Install VisualEditor and Citoid on Wikispore.Jan 11 2020, 9:07 AM

ssastry added a project: Parsing-Active-Work.Jan 22 2020, 7:01 AM

Legoktm added a parent task: T243258: Bundle VisualEditor extension with MediaWiki.Jan 22 2020, 7:07 AM

Legoktm added a project: MW-1.35-release.

Arlolra closed subtask T240054: Move top level namespace from Parsoid to Wikimedia\Parsoid as Resolved.Feb 10 2020, 11:23 PM

Change 572035 had a related patch set uploaded (by Jforrester; owner: C. Scott Ananian):
[mediawiki/core@master] Add Parsoid as a library dependency

https://gerrit.wikimedia.org/r/572035

gerritbot added a project: Patch-For-Review.Feb 13 2020, 7:11 PM

Change 572047 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/vendor@master] Add wikimedia/parsoid at 0.12.0-a1

https://gerrit.wikimedia.org/r/572047

Change 572047 merged by jenkins-bot:
[mediawiki/vendor@master] Add wikimedia/parsoid at 0.12.0-a2

https://gerrit.wikimedia.org/r/572047

Change 572035 merged by jenkins-bot:
[mediawiki/core@master] Add Parsoid as a library dependency

https://gerrit.wikimedia.org/r/572035

Maintenance_bot removed a project: Patch-For-Review.Feb 14 2020, 12:10 AM

Jdforrester-WMF mentioned this in T241961: VisualEditor was removed from Wikitech because Parsoid/PHP isn't yet compatible with how Wikitech is set up.Feb 18 2020, 6:23 PM

ssastry moved this task from Incoming to Doing (Roadmap Critical Path) on the Parsing-Active-Work board.Feb 27 2020, 1:12 AM

ssastry assigned this task to cscott.Mar 6 2020, 5:05 PM

ssastry closed subtask T213494: Installing composer modules for deployment as Resolved.Mar 8 2020, 10:06 PM

Jdforrester-WMF closed subtask T240055: Craft a deployment strategy to transition Parsoid/PHP from a faux extension to a composer library without breaking incoming requests as Resolved.Mar 13 2020, 9:12 PM

cscott added a parent task: T247804: Move Sanitizer from core into Parsoid.Mar 17 2020, 2:50 AM