Page MenuHomePhabricator

AfD form submits even if input is invalid
Open, Needs TriagePublicBUG REPORT

Description

What is the problem?

In the Articles for deletion form in the PageTriage flyout, if you enter invalid input (e.g. leave the text input empty) the form will still submit.

From experimenting, this started happening with this commit 65dad54fd759e239bf20a0267159d05a6d4e6f49 (from T231357#5553521).

Steps to reproduce problem
  1. Find an article in Special:NewPagesFeed
  2. In the PageTriage menu on the right, click the bin/delete icon and click "Articles for deletion"
  3. Without entering anything in the form, click "Mark for deletion"

Expected behavior: Popup stating "Tag afd is missing required parameter." After clicking OK, nothing else will happen.
Observed behavior: Popup stating "Tag afd is missing required parameter." After clicking OK, it continues to submit the form (going through the AfD tagging process).

Environment

Browser: Firefox 68
Wiki(s): Last reproduced: https://test.wikipedia.org MediaWiki 1.35.0-wmf.8 (rMWf20930f9c7d3) 18:32, 26 November 2019; PageTriage 0.3.0 (fec0b93) 08:24, 18 November 2019

Screenshots (if applicable):

invalid.png (397×564 px, 34 KB)