Page MenuHomePhabricator
Create Task
Maniphest T239716

CU 2.0: Use a factory to create the pager
Closed, ResolvedPublic
Actions

Description

The pager needs access to the service as well as the context (from the special page). To simplify the dependency graph, it might be best to create a factory service for the pager.

Details

SubjectRepoBranchLines +/-
Create a factory for Special:Investigate pagersmediawiki/extensions/CheckUsermaster+155 -42
Customize query in gerrit

Event Timeline

dbarratt created this task.Dec 3 2019, 2:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 3 2019, 2:37 PM
gerritbot added a comment.Dec 3 2019, 2:39 PM

Change 554299 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/extensions/CheckUser@master] Create a factory for the PreliminaryCheckPager

https://gerrit.wikimedia.org/r/554299

gerritbot added a project: Patch-For-Review.Dec 3 2019, 2:39 PM
dbarratt moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Dec 3 2019, 2:40 PM
dbarratt removed dbarratt as the assignee of this task.Dec 6 2019, 10:23 PM
dbarratt claimed this task.Jan 2 2020, 4:34 PM
dbarratt moved this task from Code Review 🔍 to In Progress 💪 on the Anti-Harassment (The Letter Song) board.Jan 16 2020, 5:28 AM
dbarratt moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Jan 22 2020, 6:25 PM
dbarratt moved this task from Code Review 🔍 to In Progress 💪 on the Anti-Harassment (The Letter Song) board.Feb 17 2020, 4:56 PM
dbarratt moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Feb 17 2020, 5:39 PM
Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Feb 19 2020, 5:54 PM
Tchanders added subscribers: dom_walden, Tchanders.EditedFeb 19 2020, 5:59 PM

@dom_walden Not sure to what extent this needs testing - it doesn't change the pagers, just how they're created. I checked the pagers are both still there and not doing anything odd.

gerritbot added a comment.Feb 19 2020, 6:06 PM

Change 554299 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Create a factory for Special:Investigate pagers

https://gerrit.wikimedia.org/r/554299

Maintenance_bot removed a project: Patch-For-Review.Feb 19 2020, 6:10 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Feb 19 2020, 7:00 PM
dom_walden moved this task from QA/Testing 🐞 to Done (2019-20: Q3) on the Anti-Harassment (The Letter Song) board.Feb 21 2020, 12:38 PM
In T239716#5898163, @Tchanders wrote:

@dom_walden Not sure to what extent this needs testing - it doesn't change the pagers, just how they're created. I checked the pagers are both still there and not doing anything odd.

OK, thats fine. Thanks!

dbarratt closed this task as Resolved.Mar 3 2020, 4:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL