Page MenuHomePhabricator

ConfirmEdit is not compatible with PHP7.4
Closed, ResolvedPublic

Description

00:04:14.499 1) ReCaptchaNoCaptchaAuthenticationRequestTest::testGetFieldInfo with data set #0 (array())
00:04:14.499 === Logs generated by test case
00:04:14.499 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
00:04:14.499 [MessageCache] [debug] MessageCache using store {class} {"class":"HashBagOStuff"}
00:04:14.499 [wfDebug] [debug] IP: 127.0.0.1 {"private":false}
00:04:14.499 ===
00:04:14.499 Trying to access array offset on value of type null
00:04:14.499 
00:04:14.499 /workspace/src/extensions/ConfirmEdit/SimpleCaptcha/SimpleCaptcha.php:195
00:04:14.499 /workspace/src/extensions/ConfirmEdit/includes/auth/CaptchaAuthenticationRequest.php:67
00:04:14.499 /workspace/src/extensions/ConfirmEdit/ReCaptchaNoCaptcha/includes/ReCaptchaNoCaptchaAuthenticationRequest.php:20
00:04:14.499 /workspace/src/tests/phpunit/includes/auth/AuthenticationRequestTestCase.php:15
00:04:14.499 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
00:04:14.499 /workspace/src/maintenance/doMaintenance.php:99
00:04:14.499 
00:04:14.499 2) ReCaptchaNoCaptchaAuthenticationRequestTest::testLoadFromSubmission with data set "no proof" (array(), array(), false)
00:04:14.499 === Logs generated by test case
00:04:14.499 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
00:04:14.499 [MessageCache] [debug] MessageCache using store {class} {"class":"HashBagOStuff"}
00:04:14.499 [wfDebug] [debug] IP: 127.0.0.1 {"private":false}
00:04:14.499 ===
00:04:14.499 Trying to access array offset on value of type null
00:04:14.499 
00:04:14.499 /workspace/src/extensions/ConfirmEdit/SimpleCaptcha/SimpleCaptcha.php:195
00:04:14.499 /workspace/src/extensions/ConfirmEdit/includes/auth/CaptchaAuthenticationRequest.php:67
00:04:14.499 /workspace/src/extensions/ConfirmEdit/ReCaptchaNoCaptcha/includes/ReCaptchaNoCaptchaAuthenticationRequest.php:20
00:04:14.499 /workspace/src/includes/auth/AuthenticationRequest.php:156
00:04:14.499 /workspace/src/extensions/ConfirmEdit/ReCaptchaNoCaptcha/includes/ReCaptchaNoCaptchaAuthenticationRequest.php:16
00:04:14.499 /workspace/src/tests/phpunit/includes/auth/AuthenticationRequestTestCase.php:83
00:04:14.499 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
00:04:14.499 /workspace/src/maintenance/doMaintenance.php:99
00:04:14.499 
00:04:14.499 3) ReCaptchaNoCaptchaAuthenticationRequestTest::testLoadFromSubmission with data set "normal" (array(), array('abc'), array('abc'))
00:04:14.499 === Logs generated by test case
00:04:14.499 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
00:04:14.499 [MessageCache] [debug] MessageCache using store {class} {"class":"HashBagOStuff"}
00:04:14.499 [wfDebug] [debug] IP: 127.0.0.1 {"private":false}
00:04:14.499 ===
00:04:14.499 Trying to access array offset on value of type null
00:04:14.499 
00:04:14.499 /workspace/src/extensions/ConfirmEdit/SimpleCaptcha/SimpleCaptcha.php:195
00:04:14.499 /workspace/src/extensions/ConfirmEdit/includes/auth/CaptchaAuthenticationRequest.php:67
00:04:14.499 /workspace/src/extensions/ConfirmEdit/ReCaptchaNoCaptcha/includes/ReCaptchaNoCaptchaAuthenticationRequest.php:20
00:04:14.499 /workspace/src/includes/auth/AuthenticationRequest.php:156
00:04:14.499 /workspace/src/extensions/ConfirmEdit/ReCaptchaNoCaptcha/includes/ReCaptchaNoCaptchaAuthenticationRequest.php:16
00:04:14.499 /workspace/src/tests/phpunit/includes/auth/AuthenticationRequestTestCase.php:83
00:04:14.499 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:416
00:04:14.499 /workspace/src/maintenance/doMaintenance.php:99

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 3 2019, 4:30 PM

Change 554337 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/ConfirmEdit@master] Pass correct type to constructor

https://gerrit.wikimedia.org/r/554337

Daimona claimed this task.Dec 3 2019, 5:11 PM

Change 554337 merged by jenkins-bot:
[mediawiki/extensions/ConfirmEdit@master] Pass correct type to constructor

https://gerrit.wikimedia.org/r/554337

Jdforrester-WMF closed this task as Resolved.Dec 3 2019, 8:54 PM