Book refs cannot extend references defined in {{#tag:references}}
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To

Authored By

	Anomie
	Dec 4 2019, 1:10 PM

Description

Consider this wikitext:

<ref extends="A">A.1</ref>

{{#tag:references|
<ref name="A">A</ref>
}}

(which is simplified from that generated by enwiki's Template:Reflist)

Expected result

Book refs bug expected.png (75×148 px, 1 KB)

Actual result on en.wikipedia.beta.wmflabs.org

Book refs bug actual.png (87×1 px, 9 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Fix incomplete undo/redo stack implementation	mediawiki/extensions/Cite	master	+10 -8
	Test cases for extends pointing to the <references> section	mediawiki/extensions/Cite	master	+43 -5

Customize query in gerrit

Related Objects

Mentioned In: rECITd07110b7901c: Fix incomplete undo/redo stack implementation
rECIT5db90fb5a968: Test cases for extends pointing to the <references> section

Event Timeline

Anomie created this task.Dec 4 2019, 1:10 PM

Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald TranscriptDec 4 2019, 1:10 PM

Change 562499 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Cite@master] Test cases for extends pointing to the <references> section

https://gerrit.wikimedia.org/r/562499

gerritbot added a project: Patch-For-Review.Jan 7 2020, 11:48 AM

Change 562499 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Test cases for extends pointing to the <references> section

https://gerrit.wikimedia.org/r/562499

thiemowmde mentioned this in rECIT5db90fb5a968: Test cases for extends pointing to the <references> section.Jan 8 2020, 10:43 AM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.15; 2020-01-14).Jan 8 2020, 11:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jan 8 2020, 11:10 AM

The error is actually with the parent ref. It must be used outside of the <references> section:

<ref extends="A">A.1</ref>
<ref name="A" />

{{#tag:references|
<ref name="A">A</ref>
}}

Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptJan 8 2020, 1:20 PM

I closed this too quickly. Behavior is indeed different if <references> is used instead, which is incorrect. The snippet given in the task description should be allowed, and implementation will require changes to the ReferenceStack "undo" logic.

Change 562854 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Cite@master] Fix incomplete undo/redo stack implementation

https://gerrit.wikimedia.org/r/562854

gerritbot added a project: Patch-For-Review.Jan 8 2020, 3:53 PM

thiemowmde claimed this task.Jan 8 2020, 3:58 PM

thiemowmde added a project: WMDE-QWERTY-Sprint-2020-01-08.

thiemowmde set the point value for this task to 5.

thiemowmde moved this task from Backlog to Tickets in sprint on the Cite-Extends board.

thiemowmde moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2020-01-08 board.

Change 562854 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Fix incomplete undo/redo stack implementation

https://gerrit.wikimedia.org/r/562854

thiemowmde mentioned this in rECITd07110b7901c: Fix incomplete undo/redo stack implementation.Jan 9 2020, 11:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jan 9 2020, 11:10 AM

WMDE-Fisch moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2020-01-08 board.Jan 15 2020, 10:54 AM

Just validated on beta.

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:38 PM

Book refs cannot extend references defined in {{#tag:references}}Closed, ResolvedPublic5 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

Book refs cannot extend references defined in {{#tag:references}}
Closed, ResolvedPublic5 Estimated Story Points
Actions