Page MenuHomePhabricator

Reader feedback generates bad png graphs on enwikinews
Closed, DeclinedPublic

Description

Reader feedback extension is generating bad png graphs (svg is fine). Letters are replaced with boxes, and there is no graph lines. This is only for some png graphs. (sorry this is not the greatest bug report, but the problem seems random to me).


Version: unspecified
Severity: major
URL: http://upload.wikimedia.org/wikinews/en/graphs/3/reliability/l31d.png

Details

Reference
bz21982

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 10:49 PM
bzimport set Reference to bz21982.
bzimport added a subscriber: Unknown Object (MLST).

This has been there for months but there seems to be no reason why the MW core SVG renderer fails to make the pngs to svgs. The SVGs are fine and the syntax is valid (1.1).

I look at those graphs every so often. This is a new issue.

Hmm, now it appears to have gone away. Perhaps it was a one-time issue

Ignore my last comment, It is still present, just only on the longer term graphs (it appears).

It appears to be a problem with how the extension calls the svg renderer. Compare:
http://upload.wikimedia.org/wikinews/en/graphs/3/reliability/l1095d.png (reliability graph last 3 months as png generated by extension)
and
https://secure.wikimedia.org/wikinews/en/wiki/File:Reliabality-wn-main_page.svg (svg reliability graph, uploaded to wikinews, and turned into a png via the normal svg image renderer).

The two images are very different.

Core/extensions both call $svgHandler->rasterize( $srcPath, $dstPath, $physicalWidth, $physicalHeight );

I looking into xml namespace issues as a possibility. Uploaded files have some stripping that takes place on upload.

(In reply to comment #6)

I looking into xml namespace issues as a possibility. Uploaded files have some
stripping that takes place on upload.

Nevermind, those are just for temp vars for virus checks.

The good png image (https://secure.wikimedia.org/wikinews/en/wiki/File:Reliabality-wn-main_page.svg) is a thumbnail that goes through the 404 handler, thumb-handler.php, and thumb.php on the image scaling cluster. The bad one is rendered on the main boxes. Imagemagik may have different versions/constrains/settings on them.

Closing all remaining ReaderFeedback tickets as Declined, since I don't think this will come back any time soon.