Page MenuHomePhabricator

No translations on Firefox Add-Ons repository
Open, Needs TriagePublicBUG REPORT

Description

What is the problem?

Currently, regardless of the language selected, you only see the English name, description, etc. of the extension.

I don't know if it would be possible to have translations.

Steps to reproduce problem
  1. Go to https://addons.mozilla.org/fr/firefox/addon/whowrotethat-beta/ (for French)
  2. You can also select the language at the bottom right of that page

Expected behavior: Name, description, etc. shows in French
Observed behavior: Shows in English

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 4 2019, 4:47 PM

According to this, the other translations are only imported when the extension is created the first time, and not when it's updated.

So this will take manual copying and pasting, the same as for T239223.

Samwilson claimed this task.EditedDec 18 2019, 7:39 AM

I've created a tool to check the listings' name and summary. PR ready for review: https://github.com/wikimedia/WhoWroteThat/pull/125

I've updated most available languages on the Firefox store, but the following are not supported:

>> Listing does not match for ksw: whowrotethat-ext-name-beta
>> Listing does not match for lb: whowrotethat-ext-name-beta
>> Listing does not match for pl: whowrotethat-ext-name-beta
>> Listing does not match for roa-tara: whowrotethat-ext-name-beta
>> Listing does not match for roa-tara: whowrotethat-ext-desc-beta
>> Listing does not match for zh-hant: whowrotethat-ext-name-beta
>> Listing does not match for zh-hant: whowrotethat-ext-desc-beta

We do have translations for zh-hant, but Firefox wants zh-cn and zh-tw; are either of these equivalent? (Translatewiki provides zh-hant, zh-hans, and zh-hk.)

We do have translations for zh-hant, but Firefox wants zh-tn and zh-tw; are either of these equivalent? (Translatewiki provides zh-hant, zh-hans, and zh-hk.)

Hm, good question. Tagging @Amire80 for potential help here. Do you have any idea of how to map these to the language codes we have, or do we not support those language variations?

Amire80 added a subscriber: abi_.

Yeah, it's possible to map language codes in translatewiki configuration. We do it for the Android apps, for example. @abi_ can probably do it most easily.

We don't need to map them to the different codes in the json files in the project, because those are all correct for MediaWiki use (which is where most of them are used). The incorrect mapping is just for the name and description, where we need to copy them in accordance with Firefox's language codes. That's a manual process anyway, so it's probably okay to make the mapping from zh-hant to zh-tn manually (i.e. hardcoded as we are doing for e.g. pt to pt-pt).

Restricted Application edited projects, added Community-Tech; removed Community-Tech (Kanban-Q3-2019-20). · View Herald TranscriptJan 7 2020, 6:38 PM

To simplify this: is it okay to use translations in zh-hant (Traditional Chinese) for zh-cn (Chinese, China)? This is what's currently shown at https://addons.mozilla.org/zh-CN/firefox/addon/whowrotethat-beta/ — is this correct?

Also, should we add the same messages for zh-tw (which currently shows the English fallback)?

PR for if the zh-hantzh-cn mapping is correct: https://github.com/wikimedia/WhoWroteThat/pull/142

As far I understand, it should be zh-hans for zh-cn (See e.g. https://en.wikipedia.org/wiki/Simplified_Chinese_characters).

Oh right, that makes sense.

This task is done for the time being then; there are no more translations to copy to the Firefox store. I'll keep an eye on it periodically and copy over any new ones or updates.

@Samwilson The German version has no description. Should it fall back to English? (https://addons.mozilla.org/de/firefox/addon/whowrotethat/)

@Samwilson The German version has no description. Should it fall back to English? (https://addons.mozilla.org/de/firefox/addon/whowrotethat/)

Oh weird: you're right, it didn't have a description. So I opened it for editing, clicked into the empty description box, then without typing anything clicked save. Now it falls back to English correctly!

Maybe it was somehow a single space character and that was trimmed when displaying for editing.

@Samwilson The German version has no description. Should it fall back to English? (https://addons.mozilla.org/de/firefox/addon/whowrotethat/)

Oh weird: you're right, it didn't have a description. So I opened it for editing, clicked into the empty description box, then without typing anything clicked save. Now it falls back to English correctly!

Thanks! In that case, this looks done.

For languages where WWT has translations, and which Firefox Addons support, these appear in Firefox Addons.