Page MenuHomePhabricator
Create Task
Maniphest T239859

ADD: ability to post comment using keyboard shortcut
Closed, ResolvedPublic
Actions

Description

Done

  • Contributors can post replies to specific comments using a keyboard shortcut, across the different keyboard configurations/platforms (e.g. Mac and Windows)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Submit on ctrl+entermediawiki/extensions/DiscussionToolsmaster+4 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

ppelberg created this task.Dec 4 2019, 9:08 PM
ppelberg updated the task description. (Show Details)Dec 4 2019, 9:13 PM
matmarex added projects: VisualEditor, DiscussionTools.Dec 5 2019, 1:52 AM
Esanders added a comment.Dec 5 2019, 4:57 PM

In Flow this is bound to CTRL+Enter

ppelberg added a comment.EditedDec 5 2019, 9:25 PM
In T239859#5715940, @Esanders wrote:

In Flow this is bound to CTRL+Enter

Let's carry that pattern here too.

gerritbot added a comment.Dec 6 2019, 5:55 PM

Change 555557 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Submit on ctrl+enter

https://gerrit.wikimedia.org/r/555557

gerritbot added a project: Patch-For-Review.Dec 6 2019, 5:55 PM
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.Dec 6 2019, 6:28 PM
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.
gerritbot added a comment.Dec 7 2019, 12:16 AM

Change 555557 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Submit on ctrl+enter

https://gerrit.wikimedia.org/r/555557

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.10; 2019-12-10).Dec 7 2019, 1:00 AM
Maintenance_bot removed a project: Patch-For-Review.Dec 7 2019, 1:10 AM
matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Dec 9 2019, 9:08 PM
Ryasmeen added a project: Verified.Dec 13 2019, 11:52 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
ppelberg closed this task as Resolved.Dec 24 2019, 5:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits