Page MenuHomePhabricator
Create Task
Maniphest T239864

[Pre-deployment testing] Getting error " Uncaught TypeError: Cannot read property 'then' of undefined" while replying to a nested reply
Closed, ResolvedPublic
Actions

Description

Getting error " Uncaught TypeError: Cannot read property 'then' of undefined" while replying to a nested reply.

Steps to reproduce:

  1. Go here: http://visualeditor-prototype.wmflabs.org/wiki/Talk:Reply_test#testing_this_chronology_business
  1. Click on the reply link next to a nested reply e.g. Reply 2

Observed Result:
Nothing happens, there is an error in the console.

Screen Shot 2019-12-04 at 1.30.45 PM.png (495×1 px, 143 KB)

Related Objects
Search...

Event Timeline

Ryasmeen created this task.Dec 4 2019, 9:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 4 2019, 9:46 PM
matmarex added projects: OWC2020, DiscussionTools.Dec 5 2019, 1:52 AM
Ryasmeen mentioned this in T239865: [Pre-deployment testing] Same reply can get posted multiple times if you click on "Reply" button multiple times.Dec 5 2019, 9:57 PM
• ppelberg merged a task: T239861: Bug: Not able to post comment on beta.Dec 5 2019, 11:14 PM
• ppelberg added subscribers: Enterprisey, TheDJ.

Provisionally merging T239861 in as a duplicate of this task. Per our discussion in today's stand: let's see if resolving this task (T239864) also takes care of T239861.

Ryasmeen added a parent task: T239961: QA Replying v1.0 on prototype server.Dec 6 2019, 12:41 AM
matmarex subscribed.Dec 7 2019, 12:46 AM

I figured out why this happens:

  • The error message indicates the exception is thrown by onReplyClick because this.comment.parsoidPromise is not set.
  • That property is set in init and there's no way in which it wouldn't be set… unless the code crashed before that point.
  • After looking at the screenshot again a couple times, I noticed that there's a yellow "warning" before the red "error" in the console – we only see the last lines of it, but that's clearly an error backtrace, and it's in yellow instead of red because it was thrown (and caught) in a jQuery Deferred.
  • Then I looked at the screenshot in T239865 and realized that's probably the same error there. It happens when we try to call highlight without specifying the comment to highlight.
  • Apparently that happens when you're not logged in – the code to highlight your latest comment has a bug and it can't find comments by anonymous users.

This will be fixed by the changes in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/552664. In the meantime, log in before testing DiscussionTools :)

Ryasmeen added a comment.Dec 12 2019, 9:15 PM

This seems to be working now for me.

Ryasmeen added a project: Verified.Dec 12 2019, 9:15 PM
matmarex closed this task as Resolved.Feb 4 2020, 4:32 PM
matmarex claimed this task.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptFeb 4 2020, 4:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL