Page MenuHomePhabricator

TemplateSandbox: clear PreviewLimitReport
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:

  1. Go to https://www.mediawiki.org/wiki/Special:TemplateSandbox?text=%3Cdiv%20style=%22float:left;height:500px;width:5em;border:solid;%22%3EAAA%3C/div%3E&page=API
  2. Press "View"

Actual Results:

The parser report appears beside the parser output, making the page confusing to look at.

Expected Results:

The parser report should appear below the parser output.

It should look similar to https://www.mediawiki.org/wiki/Special:TemplateSandbox?text=%3Cdiv%20style=%22height:500px;width:5em;border:solid;%22%3EAAA%3C/div%3E&page=API.

Solution:

The div.limitreport element should have the CSS clear: both; applied to it to prevent it from interfering with floating elements in the parser output.

Event Timeline

DannyS712 renamed this task from Clear TemplateData Parser Report to TemplateSandbox: clear PreviewLimitReport.Dec 5 2019, 1:28 AM
DannyS712 claimed this task.

Implementation:
Create a CSS module for the special page, to be added using $output->addModuleStyles()

Change 561127 had a related patch set uploaded (by BrandonXLF; owner: BrandonXLF):
[mediawiki/extensions/Echo@master] Clear LimitReport

https://gerrit.wikimedia.org/r/561127

Change 561127 abandoned by BrandonXLF:
Clear LimitReport

Reason:
Wrong project...

https://gerrit.wikimedia.org/r/561127

Change 561128 had a related patch set uploaded (by BrandonXLF; owner: BrandonXLF):
[mediawiki/extensions/TemplateSandbox@master] Clear LimitReport

https://gerrit.wikimedia.org/r/561128

Change 561128 merged by jenkins-bot:
[mediawiki/extensions/TemplateSandbox@master] Clear LimitReport

https://gerrit.wikimedia.org/r/561128