Page MenuHomePhabricator
Create Task
Maniphest T239949

[betalabs-regression] Dark navigation-drawer is displayed for a user on Homepage
Closed, ResolvedPublicBUG REPORT
Actions

Description

Instead of light "mw-mf-page-left" class="navigation-drawer", e.g.

Screen Shot 2019-12-05 at 12.58.37 PM.png (574×367 px, 33 KB)

The darker overlay will be displayed if a user clicks to invoke left-side menu (or Special:Notifications page) from Homepage.

Screen Shot 2019-12-05 at 12.51.37 PM.png (563×369 px, 32 KB)

  1. In mobile (on a real device or in a browser emulator mode), go to Special:Homepage
  2. From Homepage click to invoke the left-side menu or click on the Echo notification badge - the pages will look dark as per the screenshots above.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Suggested edits mobile: More specific selector for drawer maskmediawiki/extensions/GrowthExperimentsmaster+13 -7
Customize query in gerrit

Event Timeline

Etonkovidova created this task.Dec 5 2019, 9:04 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptDec 5 2019, 9:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kostajh claimed this task.Dec 6 2019, 12:29 PM
kostajh changed the subtype of this task from "Task" to "Bug Report".
kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
kostajh moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Dec 6 2019, 12:43 PM

Change 555473 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Suggested edits mobile: More specific selector for drawer mask

https://gerrit.wikimedia.org/r/555473

gerritbot added a project: Patch-For-Review.Dec 6 2019, 12:43 PM
kostajh moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Dec 6 2019, 12:43 PM

Good catch @Etonkovidova !

gerritbot added a comment.Dec 6 2019, 11:24 PM

Change 555473 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Suggested edits mobile: More specific selector for drawer mask

https://gerrit.wikimedia.org/r/555473

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.10; 2019-12-10).Dec 7 2019, 12:00 AM
Etonkovidova closed this task as Resolved.Dec 7 2019, 12:05 AM
Etonkovidova moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
Maintenance_bot removed a project: Patch-For-Review.Dec 7 2019, 12:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits