Page MenuHomePhabricator
Create Task
Maniphest T239968

`cli/dump.php` does not accept the --votes modifier
Closed, ResolvedPublic
Actions

Description

Attempting to run extensions/SecurePoll/cli/dump.php on mwmaint1002 as (previously) described on Wikitech throws an error, since it no longer accepts --votes as a parameter:

foks@mwmaint1002:~$ mwscript extensions/SecurePoll/cli/dump.php --wiki=enwiki --votes '2018 English Wikipedia Arbitration Committee election'
Notice: Undefined variable: wmgSessionStoreHMACKey in /srv/mediawiki/wmf-config/CommonSettings.php on line 474
Unexpected option votes!

...followed by the --help dialog.

There does not appear to be a parameter one can use to get this information into a dump (possible that I'm just missing it, but it's not addressed in the script's --help).

Details

SubjectRepoBranchLines +/-
Call addOption in constructor, not getOptionmediawiki/extensions/SecurePollmaster+4 -4
Call addOption in constructor, not getOptionmediawiki/extensions/SecurePollwmf/1.35.0-wmf.8+4 -4
Call addOption in constructor, not getOptionmediawiki/extensions/SecurePollwmf/1.35.0-wmf.5+4 -4
Customize query in gerrit

Related Objects

Event Timeline

jrbs created this task.Dec 6 2019, 12:53 AM
Restricted Application added a project: Platform Engineering. · View Herald TranscriptDec 6 2019, 12:53 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
jrbs updated the task description. (Show Details)Dec 6 2019, 12:54 AM
jrbs added a comment.Dec 6 2019, 12:59 AM

I've documented a workaround on the SecurePoll page (just in case anyone interested in the ongoing enwiki ArbCom elections sees this and is worried).

Reedy renamed this task from `extensions/SecurePoll/cli/dump.php` does not accept the --votes modifier to `cli/dump.php` does not accept the --votes modifier.Dec 6 2019, 1:14 AM
gerritbot added a comment.Dec 6 2019, 1:19 AM

Change 554983 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/SecurePoll@master] Call addOption in constructor, not getOption

https://gerrit.wikimedia.org/r/554983

gerritbot added a project: Patch-For-Review.Dec 6 2019, 1:19 AM

Change 554984 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/SecurePoll@wmf/1.35.0-wmf.5] Call addOption in constructor, not getOption

https://gerrit.wikimedia.org/r/554984

gerritbot added a comment.Dec 6 2019, 1:20 AM

Change 554985 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/SecurePoll@wmf/1.35.0-wmf.8] Call addOption in constructor, not getOption

https://gerrit.wikimedia.org/r/554985

gerritbot added a comment.Dec 6 2019, 1:23 AM

Change 554984 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@wmf/1.35.0-wmf.5] Call addOption in constructor, not getOption

https://gerrit.wikimedia.org/r/554984

Stashbot added a comment.Dec 6 2019, 1:25 AM

Mentioned in SAL (#wikimedia-operations) [2019-12-06T01:25:25Z] <reedy@deploy1001> Synchronized php-1.35.0-wmf.5/extensions/SecurePoll/cli/dump.php: T239968 (duration: 01m 01s)

gerritbot added a comment.Dec 6 2019, 1:27 AM

Change 554985 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@wmf/1.35.0-wmf.8] Call addOption in constructor, not getOption

https://gerrit.wikimedia.org/r/554985

Stashbot added a comment.Dec 6 2019, 1:34 AM

Mentioned in SAL (#wikimedia-operations) [2019-12-06T01:34:48Z] <reedy@deploy1001> Synchronized php-1.35.0-wmf.5/extensions/SecurePoll/cli/dump.php: T239968 (duration: 01m 00s)

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Dec 6 2019, 2:00 AM
Stashbot added a comment.Dec 6 2019, 2:12 AM

Mentioned in SAL (#wikimedia-operations) [2019-12-06T02:12:30Z] <reedy@deploy1001> Synchronized php-1.35.0-wmf.8/extensions/SecurePoll/cli/dump.php: T239968 (duration: 01m 04s)

Reedy closed this task as Resolved.Dec 6 2019, 2:15 AM
Reedy claimed this task.
Reedy subscribed.

Still needs merging on master

And for posterity...

mwscript extensions/SecurePoll/cli/dump.php --wiki=enwiki --votes '2018 English Wikipedia Arbitration Committee election'

needs to be

mwscript extensions/SecurePoll/cli/dump.php --wiki=votewiki --votes '2018 English Wikipedia Arbitration Committee election'

to have the desire effect ;D

jrbs added a comment.Dec 6 2019, 2:30 AM
In T239968#5717397, @Reedy wrote:

Still needs merging on master

And for posterity...

mwscript extensions/SecurePoll/cli/dump.php --wiki=enwiki --votes '2018 English Wikipedia Arbitration Committee election'

needs to be

mwscript extensions/SecurePoll/cli/dump.php --wiki=votewiki --votes '2018 English Wikipedia Arbitration Committee election'

to have the desire effect ;D

... Woops. thanks!

gerritbot added a comment.Dec 6 2019, 5:54 PM

Change 554983 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Call addOption in constructor, not getOption

https://gerrit.wikimedia.org/r/554983

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.10; 2019-12-10); removed MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Dec 6 2019, 6:00 PM
Jdforrester-WMF subscribed.Dec 6 2019, 6:05 PM

(Now merged.)

Maintenance_bot removed a project: Patch-For-Review.Dec 6 2019, 6:10 PM
Reedy mentioned this in T212027: Maintenance scripts no longer accept options.Dec 6 2019, 8:03 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL