Page MenuHomePhabricator

Review and remove unneeded wmg* variables
Open, Stalled, Needs TriagePublic

Description

Based on a manual scan, InitialiseSettings sets a number of wmg* variables to only a default value (i.e. no site-specific configuration). I propose that these variables be removed, and instead the settings in CommonSettings and elsewhere use the values currently given.

See list at P9833 (some entries have notes, starting from -has inline... anything on the line is not a part of the setting itself)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Moving code from InitialiseSettings to CommonSettings slows the site down a tad. Please wait for the migration to YAML, which won't have this limitation.

Moving code from InitialiseSettings to CommonSettings slows the site down a tad. Please wait for the migration to YAML, which won't have this limitation.

Is this T223602?

Moving code from InitialiseSettings to CommonSettings slows the site down a tad. Please wait for the migration to YAML, which won't have this limitation.

Is this T223602?

Yeah (and a few others, but that's the main work).

DannyS712 changed the task status from Open to Stalled.Dec 9 2019, 9:24 PM