Page MenuHomePhabricator

mobile-html - Article UI - [Dev] - Add language support
Open, MediumPublic

Description

  1. Fetch available languages. (page summary endpoint? JS bridge?) [DONE]
  2. Add language picker to the toolbar. Enable if there are other languages available. [DONE but always enabled]
  3. Ensure available language count also shows in article footer. [DONE]
  4. Present the available languages and push on another article view in the correct language once selected. [DONE]
  5. Ensure available languages logic works in offline mode. This might mean caching whatever response contains available languages. (or hide it, or show an error when they tap on it) [DONE]
  6. (Maybe break this off into another task) To handle language variants, we would need to store it in a separate article key and either give the user the option to switch or switch for them based on device settings. The accept-language header is what causes it to vary, so if you lookup with a URLRequest, it can reference the header to see if it matters and if so, add the variant to the key for lookup. Accept-Language, Accept-Encoding [DONE, but needs more testing]

Event Timeline

Tsevener created this task.Dec 6 2019, 5:35 PM
LGoto triaged this task as Medium priority.Dec 9 2019, 10:51 PM
LGoto moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.
Tsevener updated the task description. (Show Details)Jan 7 2020, 4:49 PM
Tsevener updated the task description. (Show Details)Jan 8 2020, 6:44 PM
Tsevener updated the task description. (Show Details)Jan 8 2020, 8:41 PM
Tsevener added a subscriber: cmadeo.Jan 9 2020, 3:20 PM

Hi @cmadeo, just wanted to confirm that we are no longer showing the languages count in the footer. Looks like it will be taken out based on the https://phabricator.wikimedia.org/T226094 comments but wanted to confirm.

cmadeo added a comment.Jan 9 2020, 8:13 PM

@Tsevener, thanks for checking in. Yep, that is correct that we will no longer be showing the languages count in the footer.

JoeWalsh updated the task description. (Show Details)Jan 24 2020, 11:19 PM
Tsevener updated the task description. (Show Details)Feb 27 2020, 7:56 PM