Page MenuHomePhabricator

mobile-html - Article UI - [Dev] -clean up and improve smoothness of inline media handling
Open, LowPublic

Description

Reference https://phabricator.wikimedia.org/T242059 for image caching backend thoughts.

  1. For images, take data provided from image caching or network, format to a model that WMFImageGalleryViewController can consume and present there upon tapping an article image. [DONE]
  2. Add header image to article view. Utilize pcs.c1.Page.getLeadImage()over JS bridge. Ensure this still works in offline mode. (Note we can also get header image from the page summary but JS call might be enough). There is a leadImageHeight JS function that we can reference to add spacing natively at the top for inserting the header image. [DONE]
  3. Add back in the header image expanding custom transition. [DONE]
  4. For audio file, hook into link clicked JS call & push to external browser based on a default conditional when checking link extension names. Default so that should we one day decide to handle audio files natively, older clients won't break.
  5. For video, experience should stay the same as before (i.e. essentially broken).

Event Timeline

LGoto triaged this task as Medium priority.Dec 9 2019, 10:50 PM
LGoto moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.
Tsevener renamed this task from mobile-html - Article UI - [Dev] - Implement gallery to mobile-html - Article UI - [Dev] - Image Handling.Jan 7 2020, 3:44 AM
Tsevener updated the task description. (Show Details)
Tsevener renamed this task from mobile-html - Article UI - [Dev] - Image Handling to mobile-html - Article UI - [Dev] - Media Handling.Jan 7 2020, 3:18 PM
Tsevener updated the task description. (Show Details)

Per our sync, we do need to have the basic meta-information for all images in the gallery saved locally, so that when viewed offline, the user will seen information like license, caption and uploader. However, we do not need to have available the highest resolution of the image, the image as embedded in the page is acceptable.

JMinor lowered the priority of this task from Medium to Low.Mar 12 2020, 7:35 PM

This is mostly done, but per meeting could be smoother, esp in lookahead on media info in gallery.

JMinor renamed this task from mobile-html - Article UI - [Dev] - Media Handling to mobile-html - Article UI - [Dev] -clean up and improve smoothness of inline media handling.May 6 2020, 9:10 PM