Flag renewals on Send to partners page
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Nikkimaria
	Dec 8 2019, 3:17 AM

Description

Task

Applications which are renewal requests are currently flagged in the Review interface, but not the 'Send to partners' interface. There are some partners for which renewals are processed differently from new accounts, so seeing the renewal flag on the Send page would be helpful.

This view class for this page is SendReadyApplicationsView: https://github.com/WikipediaLibrary/TWLight/blob/master/TWLight/applications/views.py#L1174 and the html is send_partner.html: https://github.com/WikipediaLibrary/TWLight/blob/master/TWLight/applications/templates/applications/send_partner.html

To complete this task, for each application in the for loop (https://github.com/WikipediaLibrary/TWLight/blob/master/TWLight/applications/templates/applications/send_partner.html#L124), add (renewal) if app.parent is True.

Good first bug

This task has been placed in the good first task category. This means it has been scoped and written in a way that makes it simpler for folks who haven’t contributed to the tool’s development or open source software in the past.

If that’s you, welcome! Please feel free to ask questions here about this specific task or the codebase more generally. We’ll be more than happy to help you and clarify the steps needed to complete the task, whether that’s setting up the repository, implementing the necessary changes, or pushing your changes to Github.

If you have experience contributing to this project or similar ones, please consider leaving this one for someone new, and taking a look at the Open Tasks column of the workboard for another task. Also feel free to help out if you see unanswered questions here!

How to contribute

Assign yourself to this task: Click the ‘Add Action’ dropdown menu below and then select Assign / Claim. The box should fill your username in automatically, then click Submit!

To submit your changes, you should fork the repository and create a new branch. After pushing your changes to your Github branch, you can open a pull request. Please link your pull request in a comment here when it has been submitted. Experienced contributors to the project will review your code and either provide feedback or merge it in!

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T240146 Improve coordinator workflows
		Resolved		Saloniig	T240092 Flag renewals on Send to partners page

Event Timeline

Nikkimaria created this task.Dec 8 2019, 3:17 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 8 2019, 3:17 AM

Nikkimaria added a parent task: T240146: Improve coordinator workflows.Dec 8 2019, 9:28 PM

Samwalton9-WMF moved this task from Incoming tasks to Open tasks on the Library-Card-Platform board.Jun 5 2020, 10:38 AM

Samwalton9-WMF added a project: good first task.

Samwalton9-WMF updated the task description. (Show Details)Jun 5 2020, 10:42 AM

Restricted Application added a subscriber: Sadads. · View Herald TranscriptJun 5 2020, 10:42 AM

I want to contribute to this project. Can you please tell me the url of the page on which we want to show the changes to the user. As far I have searched "/send" is the url in which we need to see the changes but at that url page is showing Not Found.
Please guide me.

@Saloniig You won't be able to see this page unless you're a coordinator or staff member. If you follow the guidance in https://github.com/WikipediaLibrary/TWLight/wiki/Local-setup and run the example data scripts, you'll be able to get a superuser account locally to see the pages and test your changes.