Page MenuHomePhabricator
Create Task
Maniphest T240117

test_namespace_methods does not validate mysite.namespace(key, True)
Closed, ResolvedPublic
Actions

Description

site_tests.TestSiteObject.test_namespace_methods has this line:

self.assertTrue(all(isinstance(mysite.namespace(key, True), Iterable) for key in ns))

but does not take into account that the result of mysite.namespace(key, False) is a str which is an Iterable too.

Details

SubjectRepoBranchLines +/-
[tests] rewrite site_tests.TestSiteObject.test_namespace_methodspywikibot/coremaster+23 -15
Customize query in gerrit

Related Objects

Event Timeline

Xqt created this task.Dec 8 2019, 7:12 PM
Restricted Application added a project: Pywikibot. · View Herald TranscriptDec 8 2019, 7:12 PM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald Transcript
Xqt triaged this task as Medium priority.Dec 8 2019, 7:13 PM
gerritbot added a comment.Dec 8 2019, 7:59 PM

Change 555744 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [tests] rewrite site_tests.TestSiteObject.test_namespace_methods

https://gerrit.wikimedia.org/r/555744

gerritbot added a project: Patch-For-Review.Dec 8 2019, 7:59 PM
Xqt claimed this task.Dec 8 2019, 7:59 PM
Xqt added a subscriber: Dvorapa.Feb 12 2020, 10:37 AM
Xqt closed this task as Resolved.Oct 28 2020, 4:49 AM
gerritbot added a comment.Oct 28 2020, 4:51 AM

Change 555744 merged by jenkins-bot:
[pywikibot/core@master] [tests] rewrite site_tests.TestSiteObject.test_namespace_methods

https://gerrit.wikimedia.org/r/555744

Xqt mentioned this in rPWBCea63efa07c7f: [tests] rewrite site_tests.TestSiteObject.test_namespace_methods.Oct 28 2020, 4:55 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 28 2020, 5:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL