Page MenuHomePhabricator
Create Task
Maniphest T240133

importImages.php ignores --dry-run
Open, Needs TriagePublic
Actions

Description

In MediaWiki 1.31.1, the script maintenance/importImages.php ignores the option --dry-run and executes the import for real.

$ php importImages.php --dry-run --comment-ext txt ~/dir
Import Images
Importing myfile.jpg...done.

$ php importImages.php --dry-run --comment-ext txt ~/dir
Import Images
myfile.jpg exists, skipping

Event Timeline

maiden_taiwan created this task.Dec 8 2019, 8:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 8 2019, 8:09 PM
Aklapper added a comment.Dec 8 2019, 9:36 PM

@maiden_taiwan: Thanks. On an unrelated not, please upgrade to a supported version. You currently run an outdated and insecure version.

maiden_taiwan added a comment.Dec 8 2019, 10:05 PM

Thanks. I upgraded to 1.31.5 a few hours ago. :-)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL