Page MenuHomePhabricator

Evaluate Library Card test coverage and design
Open, HighPublicSpike

Description

Our tests are sporadic, poorly laid out, and incomplete. We need to rethink and restructure them - this work needs to start with a review of the current situation and the best path forward for improving it.

We're already aware of the following issues, as a starting point:

  • Emails have poor test coverage (previously tracked at T196620)
  • Our test arrangement may not be ideal - each app has a single tests.py file that is often many thousands of lines long.
  • We could be using request-mocking, using something like VCR, to improve our test coverage of external dependencies.
  • Fixtures might substantially simplify our test design

Process

  • Use coveralls to evaluate the test coverage for this app
  • Consider the suitability of using fixtures in these tests to improve efficiency and reduce code
  • Evaluate whether splitting the test file into multiple would make sense, and if so how that split should happen
  • For each test, is there accurate and up to date documentation? If not, add it in.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 8 2019, 9:42 PM
Nikkimaria triaged this task as Low priority.Dec 8 2019, 9:42 PM
Samwalton9 renamed this task from Testing sprint to Improve test coverage.Dec 9 2019, 10:36 AM
Samwalton9 renamed this task from Improve test coverage to Improve test coverage and design.Feb 14 2020, 1:23 PM
Samwalton9 updated the task description. (Show Details)
Samwalton9 raised the priority of this task from Low to High.Jun 9 2020, 5:12 PM
Samwalton9 updated the task description. (Show Details)Jun 26 2020, 9:59 AM
Samwalton9 updated the task description. (Show Details)Jun 26 2020, 10:17 AM
Samwalton9 renamed this task from Improve test coverage and design to Evaluate Library Card test coverage and design.Jul 16 2020, 10:27 AM
Samwalton9 added a project: Spike.
Samwalton9 updated the task description. (Show Details)
Restricted Application changed the subtype of this task from "Task" to "Spike". · View Herald TranscriptJul 16 2020, 10:29 AM
Samwalton9 updated the task description. (Show Details)Oct 8 2020, 10:59 AM
Restricted Application added a subscriber: Sadads. · View Herald TranscriptOct 8 2020, 10:59 AM