Page MenuHomePhabricator

Remove graphs app and related code
Closed, ResolvedPublic

Description

The Library Card platform has a metrics dashboard. We stopped using much of the data on it in favour of more fine-grained data such as that from the EZProxy logs. Additionally, it stopped loading some time ago (T237721). It hasn't been displayed to users in the navigation bar for a while either.

We have determined that, given that we don't need the metrics dashboard, we can simply remove the entire graphs app. There are a handful of related areas of the codebase which can also be removed, such as the django-requests module.

Event Timeline

Samwalton9 renamed this task from Rework Metrics page to [SPIKE] Review removal of metrics dashboard.Jan 21 2021, 10:44 AM
Samwalton9 triaged this task as Medium priority.
Samwalton9 updated the task description. (Show Details)
Samwalton9 updated the task description. (Show Details)

While looking through our tech debt list to see if it's complete, I ended up answering this question:

Is the django-request module used in any other area of the codebase, or could it be safely removed alongside the dashboard?

Nope. We can drop it. It only shows up in TWLight/graphs/views.py and TWLight/graphs/tests.py

Samwalton9 renamed this task from [SPIKE] Review removal of metrics dashboard to Remove graphs app and related code.Thu, Sep 2, 12:06 PM
Samwalton9 updated the task description. (Show Details)

Are we using the jquery.flot.* JS files for something? I think this was used in the graphs app, but I don't see any more uses.

I can't think of anywhere else where we'd have used it.

PR and bugfix have been merged! I'll move this to the Done column once I check that everything is working properly

Both PRs have been merged and there are no more errors shown in GlitchTip. Moving this task to Done.